hive-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hive QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HIVE-17736) ObjectStore transaction handling can be simplified
Date Sun, 15 Oct 2017 07:13:02 GMT

    [ https://issues.apache.org/jira/browse/HIVE-17736?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16205054#comment-16205054
] 

Hive QA commented on HIVE-17736:
--------------------------------



Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12892187/HIVE-17736.01.patch

{color:red}ERROR:{color} -1 due to build exiting with an error

Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/7313/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/7313/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-7313/

Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Tests exited with: NonZeroExitCodeException
Command 'bash /data/hiveptest/working/scratch/source-prep.sh' failed with exit status 1 and
output '+ date '+%Y-%m-%d %T.%3N'
2017-10-15 07:12:46.921
+ [[ -n /usr/lib/jvm/java-8-openjdk-amd64 ]]
+ export JAVA_HOME=/usr/lib/jvm/java-8-openjdk-amd64
+ JAVA_HOME=/usr/lib/jvm/java-8-openjdk-amd64
+ export PATH=/usr/lib/jvm/java-8-openjdk-amd64/bin/:/usr/local/bin:/usr/bin:/bin:/usr/local/games:/usr/games
+ PATH=/usr/lib/jvm/java-8-openjdk-amd64/bin/:/usr/local/bin:/usr/bin:/bin:/usr/local/games:/usr/games
+ export 'ANT_OPTS=-Xmx1g -XX:MaxPermSize=256m '
+ ANT_OPTS='-Xmx1g -XX:MaxPermSize=256m '
+ export 'MAVEN_OPTS=-Xmx1g '
+ MAVEN_OPTS='-Xmx1g '
+ cd /data/hiveptest/working/
+ tee /data/hiveptest/logs/PreCommit-HIVE-Build-7313/source-prep.txt
+ [[ false == \t\r\u\e ]]
+ mkdir -p maven ivy
+ [[ git = \s\v\n ]]
+ [[ git = \g\i\t ]]
+ [[ -z master ]]
+ [[ -d apache-github-source-source ]]
+ [[ ! -d apache-github-source-source/.git ]]
+ [[ ! -d apache-github-source-source ]]
+ date '+%Y-%m-%d %T.%3N'
2017-10-15 07:12:46.950
+ cd apache-github-source-source
+ git fetch origin
+ git reset --hard HEAD
HEAD is now at 133d3c4 HIVE-17733 Move RawStore to standalone metastore. This closes #258
github PR. (Alan Gates, reviewed by Sergey Shelukhin, Vihang Karajgaonkar, and Zoltan Haindrich)
+ git clean -f -d
Removing ${project.basedir}/
Removing hbase-handler/src/java/org/apache/hadoop/hive/hbase/HBaseMetaHook.java
Removing standalone-metastore/pom.xml.orig
Removing standalone-metastore/src/gen/org/
+ git checkout master
Already on 'master'
Your branch is up-to-date with 'origin/master'.
+ git reset --hard origin/master
HEAD is now at 133d3c4 HIVE-17733 Move RawStore to standalone metastore. This closes #258
github PR. (Alan Gates, reviewed by Sergey Shelukhin, Vihang Karajgaonkar, and Zoltan Haindrich)
+ git merge --ff-only origin/master
Already up-to-date.
+ date '+%Y-%m-%d %T.%3N'
2017-10-15 07:12:53.661
+ patchCommandPath=/data/hiveptest/working/scratch/smart-apply-patch.sh
+ patchFilePath=/data/hiveptest/working/scratch/build.patch
+ [[ -f /data/hiveptest/working/scratch/build.patch ]]
+ chmod +x /data/hiveptest/working/scratch/smart-apply-patch.sh
+ /data/hiveptest/working/scratch/smart-apply-patch.sh /data/hiveptest/working/scratch/build.patch
error: a/metastore/src/java/org/apache/hadoop/hive/metastore/ObjectStore.java: No such file
or directory
error: a/metastore/src/java/org/apache/hadoop/hive/metastore/tools/HiveMetaTool.java: No such
file or directory
The patch does not appear to apply with p0, p1, or p2
+ exit 1
'
{noformat}

This message is automatically generated.

ATTACHMENT ID: 12892187 - PreCommit-HIVE-Build

> ObjectStore transaction handling can be simplified
> --------------------------------------------------
>
>                 Key: HIVE-17736
>                 URL: https://issues.apache.org/jira/browse/HIVE-17736
>             Project: Hive
>          Issue Type: Improvement
>          Components: Hive
>    Affects Versions: 3.0.0
>            Reporter: Alexander Kolbasov
>            Assignee: Alexander Kolbasov
>         Attachments: HIVE-17736.01.patch
>
>
> There are many places in ObjectStore that do something like this:
> {code}
>     boolean commited = false;
>    try {
>       openTransaction();
>       commited = commitTransaction();
>     } finally {
>       if (!commited) {
>         rollbackTransaction();
>       }
>     }
> {code}
> We can simplify this in two ways:
> 1) Create a wrapper that calls given piece of code inside the block of code above. This
is similar to TransactionManager in Sentry.
> 2) Create a special auto-closeable object that does the check and rollback on close.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message