hive-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Daniel Voros (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HIVE-17725) Fix misnamed tests which are not run during precommit runs.
Date Mon, 09 Oct 2017 16:26:00 GMT

    [ https://issues.apache.org/jira/browse/HIVE-17725?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16197232#comment-16197232
] 

Daniel Voros commented on HIVE-17725:
-------------------------------------

Yes, this change was necessary to fix the test. PrimaryToReplicaResourceFunction is using
nanoTime() instead of currentTimeMillis(), see [here|https://github.com/apache/hive/blob/f5ec4b556dd2449c118da0250715117cb7381179/ql/src/java/org/apache/hadoop/hive/ql/parse/repl/load/message/CreateFunctionHandler.java#L191].

> Fix misnamed tests which are not run during precommit runs. 
> ------------------------------------------------------------
>
>                 Key: HIVE-17725
>                 URL: https://issues.apache.org/jira/browse/HIVE-17725
>             Project: Hive
>          Issue Type: Bug
>          Components: Test
>            Reporter: Zoltan Haindrich
>            Assignee: Daniel Voros
>         Attachments: HIVE-17725.1.patch, HIVE-17725.2.patch
>
>
> I've just seen a testfailure for jdk9; but the test is not even executed during precommit
runs:
> {{TaskTrackerTest}}
> I think the test classes name should match the {{\*\*/Test\*}} to be executed during
test runs...however there seems to be quite a few... {{find . -name '*Test.java'}} returns
a few abstracts ; but there are real test ; which are just misnamed...



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message