hive-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alan Gates (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HIVE-16722) Converting bucketed non-acid table to acid should perform validation
Date Thu, 19 Oct 2017 19:54:00 GMT

    [ https://issues.apache.org/jira/browse/HIVE-16722?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16211632#comment-16211632
] 

Alan Gates commented on HIVE-16722:
-----------------------------------

Small nit:  rather than creating a new instance of the Warehouse in validateTableStructures
you can fetch it from the HMSHandler that is passed along with the PreAlterTableEvent.

Other than that +1.

> Converting bucketed non-acid table to acid should perform validation
> --------------------------------------------------------------------
>
>                 Key: HIVE-16722
>                 URL: https://issues.apache.org/jira/browse/HIVE-16722
>             Project: Hive
>          Issue Type: Sub-task
>          Components: Transactions
>    Affects Versions: 1.0.0
>            Reporter: Eugene Koifman
>            Assignee: Eugene Koifman
>         Attachments: HIVE-16722.01.patch, HIVE-16722.02.patch, HIVE-16722.03.patch, HIVE-16722.WIP.patch
>
>
> Converting a non acid table to acid only performs metadata validation (in _TransactionalValidationListener_).
> The data read code path only understands certain directory layouts and file names and
ignores (generally) files that don't match the expected format.
> In Hive, directory layout and bucket file naming (especially older releases) is poorly
enforced.
> Need to add a validation step on 
> {noformat}
> alter table T SET TBLPROPERTIES ('transactional'='true')
> {noformat}
> to 
> scan the file system and report any possible data loss scenarios.
> Currently Acid understands bucket files name like "00000_0" and (with HIVE-16177) 00000_0_copy1"
etc at the root of the partition.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message