Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 6A05A200CFC for ; Thu, 28 Sep 2017 23:14:11 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 6889A1609B4; Thu, 28 Sep 2017 21:14:11 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id A4F701609EC for ; Thu, 28 Sep 2017 23:14:10 +0200 (CEST) Received: (qmail 16410 invoked by uid 500); 28 Sep 2017 21:14:09 -0000 Mailing-List: contact issues-help@hive.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hive.apache.org Delivered-To: mailing list issues@hive.apache.org Received: (qmail 16373 invoked by uid 99); 28 Sep 2017 21:14:09 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 28 Sep 2017 21:14:09 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id 0590E180A34 for ; Thu, 28 Sep 2017 21:14:09 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -99.201 X-Spam-Level: X-Spam-Status: No, score=-99.201 tagged_above=-999 required=6.31 tests=[KAM_ASCII_DIVIDERS=0.8, RP_MATCHES_RCVD=-0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id eH1eZ0vEZZPB for ; Thu, 28 Sep 2017 21:14:08 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id C26F95FE43 for ; Thu, 28 Sep 2017 21:14:07 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id DA28FE0EEF for ; Thu, 28 Sep 2017 21:14:06 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 2FEAA24286 for ; Thu, 28 Sep 2017 21:14:06 +0000 (UTC) Date: Thu, 28 Sep 2017 21:14:06 +0000 (UTC) From: "Vineet Garg (JIRA)" To: issues@hive.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HIVE-17634) Use properties from HiveConf about "fetchColStats" and "fetchPartStats" in RelOptHiveTable#updateColStats MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Thu, 28 Sep 2017 21:14:11 -0000 [ https://issues.apache.org/jira/browse/HIVE-17634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16184886#comment-16184886 ] Vineet Garg commented on HIVE-17634: ------------------------------------ I confirmed this with [~ashutoshc] that logical planning indeed uses 'true' on purpose to always use column stats. So it should not be changed to make it use {{hive.stats.fetch.column.stats}} & {{hive.stats.fetch.partition.stats}} confs. > Use properties from HiveConf about "fetchColStats" and "fetchPartStats" in RelOptHiveTable#updateColStats > --------------------------------------------------------------------------------------------------------- > > Key: HIVE-17634 > URL: https://issues.apache.org/jira/browse/HIVE-17634 > Project: Hive > Issue Type: Bug > Reporter: liyunzhang_intel > Assignee: liyunzhang_intel > Attachments: HIVE-17634.patch > > > in [RelOptHiveTable#updateColStats|https://github.com/apache/hive/blob/master/ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/RelOptHiveTable.java#L309], we set {{fetchColStats}},{{fetchPartStats}} as true when call {{StatsUtils.collectStatistics}} > {code} > if (!hiveTblMetadata.isPartitioned()) { > // 2.1 Handle the case for unpartitioned table. > try { > Statistics stats = StatsUtils.collectStatistics(hiveConf, null, > hiveTblMetadata, hiveNonPartitionCols, nonPartColNamesThatRqrStats, > colStatsCached, nonPartColNamesThatRqrStats, true, true); > ... > {code} > This will cause querying columns statistic from metastore even we set {{hive.stats.fetch.column.stats}} and {{hive.stats.fetch.partition.stats}} as false in HiveConf. If we these two properties as false, we can not any column statistics from metastore. Suggest to set the properties from HiveConf. -- This message was sent by Atlassian JIRA (v6.4.14#64029)