Mailing-List: contact issues-help@hive.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@hive.apache.org
Date: Wed, 20 Sep 2017 19:40:00 +0000 (UTC)
From: "Jesus Camacho Rodriguez (JIRA)" <jira@apache.org>
To: issues@hive.apache.org
Message-ID: <JIRA.13101506.1505175739000.160411.1505936400231@Atlassian.JIRA>
In-Reply-To: <JIRA.13101506.1505175739000@Atlassian.JIRA>
References: <JIRA.13101506.1505175739000@Atlassian.JIRA> <JIRA.13101506.1505175739410@jira-lw-us.apache.org>
Subject: [jira] [Updated] (HIVE-17510) Make comparison of filter predicates
 in q files deterministic
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Wed, 20 Sep 2017 19:40:05 -0000


     [ https://issues.apache.org/jira/browse/HIVE-17510?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jesus Camacho Rodriguez updated HIVE-17510:
-------------------------------------------
       Resolution: Fixed
    Fix Version/s: 3.0.0
           Status: Resolved  (was: Patch Available)

Regenerated last couple of needed q files and verified unrelated failures. Pushed to master, thanks for reviewing [~ashutoshc]!

> Make comparison of filter predicates in q files deterministic
> -------------------------------------------------------------
>
>                 Key: HIVE-17510
>                 URL: https://issues.apache.org/jira/browse/HIVE-17510
>             Project: Hive
>          Issue Type: Bug
>          Components: Testing Infrastructure
>    Affects Versions: 3.0.0
>            Reporter: Jesus Camacho Rodriguez
>            Assignee: Jesus Camacho Rodriguez
>             Fix For: 3.0.0
>
>         Attachments: HIVE-17510.01.patch, HIVE-17510.patch
>
>
> I have been hitting this issue while submitting patches to test HIVE-17432.
> Basically, the order on which the rewriting might create the children of AND operations is not deterministic. Thus, tests might fail because the created golden file is not the same, thought the test should pass because they just simply do not follow same order:
> {code}
> predicate: ((d_year >= 1992) and (d_year <= 1997) and ((c_city = 'UNITED KI1') or (c_city = 'UNITED KI5')) and ((s_city = 'UNITED KI1') or (s_city = 'UNITED KI5'))) (type: boolean)
> {code}
> {code}
> predicate: ((d_year <= 1997) and (d_year >= 1992) and ((c_city = 'UNITED KI1') or (c_city = 'UNITED KI5')) and ((s_city = 'UNITED KI1') or (s_city = 'UNITED KI5'))) (type: boolean)
> {code}
> This patches fixes the issue by sorting the children of some expressions (currently AND and OR children) when we run explain plan and we are running in test mode.


--
This message was sent by Atlassian JIRA
(v6.4.14#64029)