hive-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jesus Camacho Rodriguez (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HIVE-17468) Shade and package appropriate jackson version for druid storage handler
Date Thu, 07 Sep 2017 16:07:00 GMT

    [ https://issues.apache.org/jira/browse/HIVE-17468?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16157142#comment-16157142
] 

Jesus Camacho Rodriguez commented on HIVE-17468:
------------------------------------------------

[~bslim], about the avatica dependency, I am not sure, I think it is not needed. About calcite,
a quick check shows that it is used by the record writer, which is executed by the clients
writing the records in Druid and thus might not have Calcite in their classpath. That must
be the reason why it is included in the uber jar (you can double check if there are other
classes that are not executed at HS2 side that need it, I did not check further).

> Shade and package appropriate jackson version for druid storage handler
> -----------------------------------------------------------------------
>
>                 Key: HIVE-17468
>                 URL: https://issues.apache.org/jira/browse/HIVE-17468
>             Project: Hive
>          Issue Type: Bug
>            Reporter: slim bouguerra
>            Assignee: Jesus Camacho Rodriguez
>             Fix For: 3.0.0
>
>         Attachments: HIVE-17468.2.patch, HIVE-17468.patch, hive-druid-deps.txt
>
>
> Currently we are excluding all the jackson core dependencies coming from druid. This
is wrong in my opinion since this will lead to the packaging of unwanted jackson library from
other projects.
> As you can see the file hive-druid-deps.txt currently jacskon core is coming from calcite
and the version is 2.6.3 which is very different from 2.4.6 used by druid. This patch exclude
the unwanted jars and make sure to bring in druid jackson dependency from druid it self.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message