hive-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hive QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HIVE-17405) HoS DPP ConstantPropagate should use ConstantPropagateOption.SHORTCUT
Date Fri, 01 Sep 2017 13:34:00 GMT

    [ https://issues.apache.org/jira/browse/HIVE-17405?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16150526#comment-16150526
] 

Hive QA commented on HIVE-17405:
--------------------------------



Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12884864/HIVE-17405.7.patch

{color:green}SUCCESS:{color} +1 due to 1 test(s) being added or modified.

{color:red}ERROR:{color} -1 due to 4 failed/errored test(s), 11023 tests executed
*Failed tests:*
{noformat}
TestTxnCommandsBase - did not produce a TEST-*.xml file (likely timed out) (batchId=280)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[insert_values_orig_table_use_metadata]
(batchId=61)
org.apache.hadoop.hive.cli.TestPerfCliDriver.testCliDriver[query14] (batchId=234)
org.apache.hadoop.hive.ql.lockmgr.TestDbTxnManager2.insertOverwriteCreate (batchId=282)
{noformat}

Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/6639/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/6639/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-6639/

Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
Tests exited with: TestsFailedException: 4 tests failed
{noformat}

This message is automatically generated.

ATTACHMENT ID: 12884864 - PreCommit-HIVE-Build

> HoS DPP ConstantPropagate should use ConstantPropagateOption.SHORTCUT
> ---------------------------------------------------------------------
>
>                 Key: HIVE-17405
>                 URL: https://issues.apache.org/jira/browse/HIVE-17405
>             Project: Hive
>          Issue Type: Sub-task
>          Components: Spark
>            Reporter: Sahil Takiar
>            Assignee: Sahil Takiar
>         Attachments: HIVE-17405.1.patch, HIVE-17405.2.patch, HIVE-17405.3.patch, HIVE-17405.4.patch,
HIVE-17405.5.patch, HIVE-17405.6.patch, HIVE-17405.7.patch
>
>
> In {{SparkCompiler#runDynamicPartitionPruning}} we should change {{new ConstantPropagate().transform(parseContext)}}
to {{new ConstantPropagate(ConstantPropagateOption.SHORTCUT).transform(parseContext)}}
> Hive-on-Tez does the same thing.
> Running the full constant propagation isn't really necessary, we just want to eliminate
any {{and true}} predicates that were introduced by {{SyntheticJoinPredicate}} and {{DynamicPartitionPruningOptimization}}.
The {{SyntheticJoinPredicate}} will introduce dummy filter predicates into the operator tree,
and {{DynamicPartitionPruningOptimization}} will replace them. The predicates introduced via
{{SyntheticJoinPredicate}} are necessary to help {{DynamicPartitionPruningOptimization}} determine
if DPP can be used or not.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message