hive-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Zoltan Haindrich (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (HIVE-17313) Potentially possible 'case fall through' in the ObjectInspectorConverters
Date Fri, 15 Sep 2017 09:07:00 GMT

     [ https://issues.apache.org/jira/browse/HIVE-17313?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Zoltan Haindrich updated HIVE-17313:
------------------------------------
       Resolution: Fixed
    Fix Version/s: 3.0.0
           Status: Resolved  (was: Patch Available)

pushed to master, Thank you [~olegd] for fixing it!

> Potentially possible 'case fall through' in the ObjectInspectorConverters
> -------------------------------------------------------------------------
>
>                 Key: HIVE-17313
>                 URL: https://issues.apache.org/jira/browse/HIVE-17313
>             Project: Hive
>          Issue Type: Bug
>            Reporter: Oleg Danilov
>            Assignee: Oleg Danilov
>            Priority: Trivial
>             Fix For: 3.0.0
>
>         Attachments: HIVE-17313.patch
>
>
> Lines 103-110:
> {code:java}
>     case STRING:
>       if (outputOI instanceof WritableStringObjectInspector) {
>         return new PrimitiveObjectInspectorConverter.TextConverter(
>             inputOI);
>       } else if (outputOI instanceof JavaStringObjectInspector) {
>         return new PrimitiveObjectInspectorConverter.StringConverter(
>             inputOI);
>       }
>     case CHAR:
> {code}
> De-facto it should work correctly since outputOI is either an instance of WritableStringObjectInspector
or JavaStringObjectInspector, but it would be better to rewrite this case to avoid possible
fall through.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message