hive-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ferdinand Xu (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HIVE-15053) Beeline#addlocaldriver - reduce classpath scanning
Date Fri, 15 Sep 2017 13:54:00 GMT

    [ https://issues.apache.org/jira/browse/HIVE-15053?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16167888#comment-16167888
] 

Ferdinand Xu commented on HIVE-15053:
-------------------------------------

Thanks [~kgyrtkirk]. The patch did avoid the classpath scan for driver. Just as [~pvary] mentioned,
I am not quite sure about whether it's compatible for other drivers who is not service loadable
(if exists). Regards to a cleaner code, any other benefits we can have like performance? 

> Beeline#addlocaldriver - reduce classpath scanning
> --------------------------------------------------
>
>                 Key: HIVE-15053
>                 URL: https://issues.apache.org/jira/browse/HIVE-15053
>             Project: Hive
>          Issue Type: Improvement
>            Reporter: Zoltan Haindrich
>            Assignee: Zoltan Haindrich
>         Attachments: HIVE-15053.1.patch, HIVE-15053.1.patch, HIVE-15053.1.patch, HIVE-15053.2.patch,
HIVE-15053.3.patch
>
>
> There is a classpath scanning machinery inside {{ClassNameCompleter}}.
> I think the sole purpose of these things is to scan for jdbc drivers...(but not entirely
sure)
> if it is indeed looking for jdbc drivers..then possibly this can be removed without any
issues because modern jdbc drivers usually advertise their driver as a service-loadable class
for {{java.sql.Driver}}
> http://www.onjava.com/2006/08/02/jjdbc-4-enhancements-in-java-se-6.html
> Auto-Loading of JDBC Driver



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message