Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id CB235200CF3 for ; Tue, 15 Aug 2017 08:22:13 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id C22351664CC; Tue, 15 Aug 2017 06:22:13 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 1C67B1664C9 for ; Tue, 15 Aug 2017 08:22:12 +0200 (CEST) Received: (qmail 27049 invoked by uid 500); 15 Aug 2017 06:22:12 -0000 Mailing-List: contact issues-help@hive.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hive.apache.org Delivered-To: mailing list issues@hive.apache.org Received: (qmail 27038 invoked by uid 99); 15 Aug 2017 06:22:12 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 15 Aug 2017 06:22:12 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id A3C8318041D for ; Tue, 15 Aug 2017 06:22:11 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -99.202 X-Spam-Level: X-Spam-Status: No, score=-99.202 tagged_above=-999 required=6.31 tests=[KAM_ASCII_DIVIDERS=0.8, RP_MATCHES_RCVD=-0.001, SPF_PASS=-0.001, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id bIb49whlM22m for ; Tue, 15 Aug 2017 06:22:09 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id E71705FDFA for ; Tue, 15 Aug 2017 06:22:08 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id EFDC1E095A for ; Tue, 15 Aug 2017 06:22:06 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 390572140D for ; Tue, 15 Aug 2017 06:22:03 +0000 (UTC) Date: Tue, 15 Aug 2017 06:22:03 +0000 (UTC) From: "Thejas M Nair (JIRA)" To: issues@hive.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HIVE-17315) Make the DataSource used by the DataNucleus in the HMS configurable using Hive properties MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Tue, 15 Aug 2017 06:22:14 -0000 [ https://issues.apache.org/jira/browse/HIVE-17315?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16126852#comment-16126852 ] Thejas M Nair commented on HIVE-17315: -------------------------------------- bq. Even if the current properties are safe, I would be afraid of what could be added by future versions of the connection pool implementations, since we would be exposing these settings the moment we upgrade the library. Other than password, I don't expect any other confidential property to be used by connection pool. Hiding properties by default would cause difficulty in debugging issues. This is also counter to the practice we follow with other types of configs such as hdfs, yarn, tez, spark etc (ie, we don't hide those properties by default) > Make the DataSource used by the DataNucleus in the HMS configurable using Hive properties > ----------------------------------------------------------------------------------------- > > Key: HIVE-17315 > URL: https://issues.apache.org/jira/browse/HIVE-17315 > Project: Hive > Issue Type: New Feature > Affects Versions: 3.0.0 > Reporter: Barna Zsombor Klara > Assignee: Barna Zsombor Klara > > Currently we may use several connection pool implementations in the backend (hikari, dbCp, boneCp) but these can only be configured using proprietary xml files and not through hive-site.xml like DataNucleus. > We should make them configurable just like DataNucleus, by allowing Hive properties prefix by hikari, dbcp, bonecp to be set in the hive-site.xml. However since these configurations may contain sensitive information (passwords) these properties should not be displayable or manually settable. -- This message was sent by Atlassian JIRA (v6.4.14#64029)