Mailing-List: contact issues-help@hive.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@hive.apache.org
Date: Thu, 17 Aug 2017 07:44:00 +0000 (UTC)
From: "Zoltan Haindrich (JIRA)" <jira@apache.org>
To: issues@hive.apache.org
Message-ID: <JIRA.13094440.1502710945000.52154.1502955840207@Atlassian.JIRA>
In-Reply-To: <JIRA.13094440.1502710945000@Atlassian.JIRA>
References: <JIRA.13094440.1502710945000@Atlassian.JIRA> <JIRA.13094440.1502710945128@jira-lw-us.apache.org>
Subject: [jira] [Commented] (HIVE-17314)
 LazySimpleSerializeWrite.writeString() contains if with an empty body
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Thu, 17 Aug 2017 07:44:06 -0000


    [ https://issues.apache.org/jira/browse/HIVE-17314?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16130058#comment-16130058 ] 

Zoltan Haindrich commented on HIVE-17314:
-----------------------------------------

Seems like this extra if have been introduced in:
https://github.com/apache/hive/commit/d467e172262c23b97e1d55e35798ba530cae5972#diff-b767e13919b57d8131358345ea7192e5R234
Could you upload the patch here as well?
+1

> LazySimpleSerializeWrite.writeString() contains if with an empty body
> ---------------------------------------------------------------------
>
>                 Key: HIVE-17314
>                 URL: https://issues.apache.org/jira/browse/HIVE-17314
>             Project: Hive
>          Issue Type: Bug
>            Reporter: Oleg Danilov
>            Assignee: Oleg Danilov
>            Priority: Minor
>
> Looking at the LazySimpleSerializeWrite.java I found odd 'if':
> Lines 234-235:
> {code:java}
>     if (v.equals(nullSequenceBytes)) {
>     }
> {code}
> Seems like either something is missed there or this 'if' could be dropped out.


--
This message was sent by Atlassian JIRA
(v6.4.14#64029)