Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id B9E45200CE6 for ; Wed, 2 Aug 2017 04:15:09 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id B83751687AF; Wed, 2 Aug 2017 02:15:09 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id D7D791687AE for ; Wed, 2 Aug 2017 04:15:08 +0200 (CEST) Received: (qmail 7638 invoked by uid 500); 2 Aug 2017 02:15:08 -0000 Mailing-List: contact issues-help@hive.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hive.apache.org Delivered-To: mailing list issues@hive.apache.org Received: (qmail 7629 invoked by uid 99); 2 Aug 2017 02:15:08 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 02 Aug 2017 02:15:08 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id 9756CC004A for ; Wed, 2 Aug 2017 02:15:07 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -97.201 X-Spam-Level: X-Spam-Status: No, score=-97.201 tagged_above=-999 required=6.31 tests=[KAM_ASCII_DIVIDERS=0.8, KAM_BADIPHTTP=2, NORMAL_HTTP_TO_IP=0.001, RP_MATCHES_RCVD=-0.001, SPF_PASS=-0.001, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id gcuNzrZ03TT1 for ; Wed, 2 Aug 2017 02:15:05 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id 957C85F3D1 for ; Wed, 2 Aug 2017 02:15:04 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id D303DE012F for ; Wed, 2 Aug 2017 02:15:03 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 40BA62465C for ; Wed, 2 Aug 2017 02:15:01 +0000 (UTC) Date: Wed, 2 Aug 2017 02:15:01 +0000 (UTC) From: "Hive QA (JIRA)" To: issues@hive.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HIVE-17220) Bloomfilter probing in semijoin reduction is thrashing L1 dcache MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Wed, 02 Aug 2017 02:15:09 -0000 [ https://issues.apache.org/jira/browse/HIVE-17220?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16110143#comment-16110143 ] Hive QA commented on HIVE-17220: -------------------------------- Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/12879912/HIVE-17220.1.patch {color:green}SUCCESS:{color} +1 due to 1 test(s) being added or modified. {color:red}ERROR:{color} -1 due to 12 failed/errored test(s), 11058 tests executed *Failed tests:* {noformat} TestPerfCliDriver - did not produce a TEST-*.xml file (likely timed out) (batchId=236) org.apache.hadoop.hive.cli.TestMiniSparkOnYarnCliDriver.testCliDriver[spark_vectorized_dynamic_partition_pruning] (batchId=168) org.apache.hive.common.util.TestBloom1Filter.testBloom1FilterByte (batchId=178) org.apache.hive.common.util.TestBloom1Filter.testBloom1FilterBytes (batchId=178) org.apache.hive.common.util.TestBloom1Filter.testBloom1FilterDouble (batchId=178) org.apache.hive.common.util.TestBloom1Filter.testBloom1FilterFloat (batchId=178) org.apache.hive.common.util.TestBloom1Filter.testBloom1FilterInt (batchId=178) org.apache.hive.common.util.TestBloom1Filter.testBloom1FilterLong (batchId=178) org.apache.hive.common.util.TestBloom1Filter.testBloom1FilterString (batchId=178) org.apache.hive.hcatalog.api.TestHCatClient.testPartitionRegistrationWithCustomSchema (batchId=179) org.apache.hive.hcatalog.api.TestHCatClient.testPartitionSpecRegistrationWithCustomSchema (batchId=179) org.apache.hive.hcatalog.api.TestHCatClient.testTableSchemaPropagation (batchId=179) {noformat} Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/6221/testReport Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/6221/console Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-6221/ Messages: {noformat} Executing org.apache.hive.ptest.execution.TestCheckPhase Executing org.apache.hive.ptest.execution.PrepPhase Executing org.apache.hive.ptest.execution.ExecutionPhase Executing org.apache.hive.ptest.execution.ReportingPhase Tests exited with: TestsFailedException: 12 tests failed {noformat} This message is automatically generated. ATTACHMENT ID: 12879912 - PreCommit-HIVE-Build > Bloomfilter probing in semijoin reduction is thrashing L1 dcache > ---------------------------------------------------------------- > > Key: HIVE-17220 > URL: https://issues.apache.org/jira/browse/HIVE-17220 > Project: Hive > Issue Type: Bug > Affects Versions: 3.0.0 > Reporter: Prasanth Jayachandran > Assignee: Prasanth Jayachandran > Attachments: HIVE-17220.1.patch, HIVE-17220.WIP.patch > > > [~gopalv] observed perf profiles showing bloomfilter probes as bottleneck for some of the TPC-DS queries and resulted L1 data cache thrashing. > This is because of the huge bitset in bloom filter that doesn't fit in any levels of cache, also the hash bits corresponding to a single key map to different segments of bitset which are spread out. This can result in K-1 memory access (K being number of hash functions) in worst case for every key that gets probed because of locality miss in L1 cache. > Ran a JMH microbenchmark to verify the same. Following is the JMH perf profile for bloom filter probing > {code} > Perf stats: > -------------------------------------------------- > 5101.935637 task-clock (msec) # 0.461 CPUs utilized > 346 context-switches # 0.068 K/sec > 336 cpu-migrations # 0.066 K/sec > 6,207 page-faults # 0.001 M/sec > 10,016,486,301 cycles # 1.963 GHz (26.90%) > 5,751,692,176 stalled-cycles-frontend # 57.42% frontend cycles idle (27.05%) > stalled-cycles-backend > 14,359,914,397 instructions # 1.43 insns per cycle > # 0.40 stalled cycles per insn (33.78%) > 2,200,632,861 branches # 431.333 M/sec (33.84%) > 1,162,860 branch-misses # 0.05% of all branches (33.97%) > 1,025,992,254 L1-dcache-loads # 201.099 M/sec (26.56%) > 432,663,098 L1-dcache-load-misses # 42.17% of all L1-dcache hits (14.49%) > 331,383,297 LLC-loads # 64.952 M/sec (14.47%) > 203,524 LLC-load-misses # 0.06% of all LL-cache hits (21.67%) > L1-icache-loads > 1,633,821 L1-icache-load-misses # 0.320 M/sec (28.85%) > 950,368,796 dTLB-loads # 186.276 M/sec (28.61%) > 246,813,393 dTLB-load-misses # 25.97% of all dTLB cache hits (14.53%) > 25,451 iTLB-loads # 0.005 M/sec (14.48%) > 35,415 iTLB-load-misses # 139.15% of all iTLB cache hits (21.73%) > L1-dcache-prefetches > 175,958 L1-dcache-prefetch-misses # 0.034 M/sec (28.94%) > 11.064783140 seconds time elapsed > {code} > This shows 42.17% of L1 data cache misses. > This jira is to use cache efficient bloom filter for semijoin probing. -- This message was sent by Atlassian JIRA (v6.4.14#64029)