hive-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sahil Takiar (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HIVE-17405) HoS DPP ConstantPropagate should use ConstantPropagateOption.SHORTCUT
Date Wed, 30 Aug 2017 04:37:00 GMT

    [ https://issues.apache.org/jira/browse/HIVE-17405?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16146590#comment-16146590
] 

Sahil Takiar commented on HIVE-17405:
-------------------------------------

Oh wow, thanks for pointing that out [~lirui]! I didn't even notice. TBH not really sure why
it fixes spark_vectorized_dynamic_partition_pruning.q, I can try to dig into it some more.
Attached an updated patch with an re-generated spark_vectorized_dynamic_partition_pruning.q.out
file. 

> HoS DPP ConstantPropagate should use ConstantPropagateOption.SHORTCUT
> ---------------------------------------------------------------------
>
>                 Key: HIVE-17405
>                 URL: https://issues.apache.org/jira/browse/HIVE-17405
>             Project: Hive
>          Issue Type: Sub-task
>          Components: Spark
>            Reporter: Sahil Takiar
>            Assignee: Sahil Takiar
>         Attachments: HIVE-17405.1.patch, HIVE-17405.2.patch, HIVE-17405.3.patch
>
>
> In {{SparkCompiler#runDynamicPartitionPruning}} we should change {{new ConstantPropagate().transform(parseContext)}}
to {{new ConstantPropagate(ConstantPropagateOption.SHORTCUT).transform(parseContext)}}
> Hive-on-Tez does the same thing.
> Running the full constant propagation isn't really necessary, we just want to eliminate
any {{and true}} predicates that were introduced by {{SyntheticJoinPredicate}} and {{DynamicPartitionPruningOptimization}}.
The {{SyntheticJoinPredicate}} will introduce dummy filter predicates into the operator tree,
and {{DynamicPartitionPruningOptimization}} will replace them. The predicates introduced via
{{SyntheticJoinPredicate}} are necessary to help {{DynamicPartitionPruningOptimization}} determine
if DPP can be used or not.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message