hive-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Oleg Danilov (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (HIVE-17331) Path must be used as key type of the pathToAlises
Date Wed, 16 Aug 2017 08:34:00 GMT

     [ https://issues.apache.org/jira/browse/HIVE-17331?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Oleg Danilov updated HIVE-17331:
--------------------------------
    Description: 
This code uses String instead of Path as key type of the pathToAlises map, so seems like get(String)
always null.

+*GenMapRedUtils.java*+
{code:java}
        for (int pos = 0; pos < size; pos++) {
          String taskTmpDir = taskTmpDirLst.get(pos);
          TableDesc tt_desc = tt_descLst.get(pos);
          MapWork mWork = plan.getMapWork();
          if (mWork.getPathToAliases().get(taskTmpDir) == null) {
            taskTmpDir = taskTmpDir.intern();
            Path taskTmpDirPath = StringInternUtils.internUriStringsInPath(new Path(taskTmpDir));
            mWork.removePathToAlias(taskTmpDirPath);
            mWork.addPathToAlias(taskTmpDirPath, taskTmpDir);
            mWork.addPathToPartitionInfo(taskTmpDirPath, new PartitionDesc(tt_desc, null));
            mWork.getAliasToWork().put(taskTmpDir, topOperators.get(pos));
{code}


  was:
This code uses String instead of Path as key type of the pathToAlises, so seems like get(String)
always null.

+*GenMapRedUtils.java*+
{code:java}
        for (int pos = 0; pos < size; pos++) {
          *String taskTmpDir* = taskTmpDirLst.get(pos);
          TableDesc tt_desc = tt_descLst.get(pos);
          MapWork mWork = plan.getMapWork();
          if (mWork.getPathToAliases().*get(taskTmpDir)* == null) {
            taskTmpDir = taskTmpDir.intern();
            Path taskTmpDirPath = StringInternUtils.internUriStringsInPath(new Path(taskTmpDir));
            mWork.removePathToAlias(taskTmpDirPath);
            mWork.addPathToAlias(taskTmpDirPath, taskTmpDir);
            mWork.addPathToPartitionInfo(taskTmpDirPath, new PartitionDesc(tt_desc, null));
            mWork.getAliasToWork().put(taskTmpDir, topOperators.get(pos));
{code}



> Path must be used as key type of the pathToAlises
> -------------------------------------------------
>
>                 Key: HIVE-17331
>                 URL: https://issues.apache.org/jira/browse/HIVE-17331
>             Project: Hive
>          Issue Type: Bug
>            Reporter: Oleg Danilov
>            Assignee: Oleg Danilov
>            Priority: Minor
>
> This code uses String instead of Path as key type of the pathToAlises map, so seems like
get(String) always null.
> +*GenMapRedUtils.java*+
> {code:java}
>         for (int pos = 0; pos < size; pos++) {
>           String taskTmpDir = taskTmpDirLst.get(pos);
>           TableDesc tt_desc = tt_descLst.get(pos);
>           MapWork mWork = plan.getMapWork();
>           if (mWork.getPathToAliases().get(taskTmpDir) == null) {
>             taskTmpDir = taskTmpDir.intern();
>             Path taskTmpDirPath = StringInternUtils.internUriStringsInPath(new Path(taskTmpDir));
>             mWork.removePathToAlias(taskTmpDirPath);
>             mWork.addPathToAlias(taskTmpDirPath, taskTmpDir);
>             mWork.addPathToPartitionInfo(taskTmpDirPath, new PartitionDesc(tt_desc, null));
>             mWork.getAliasToWork().put(taskTmpDir, topOperators.get(pos));
> {code}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message