hive-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Zoltan Haindrich (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HIVE-17314) LazySimpleSerializeWrite.writeString() contains if with an empty body
Date Thu, 17 Aug 2017 07:44:00 GMT

    [ https://issues.apache.org/jira/browse/HIVE-17314?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16130058#comment-16130058
] 

Zoltan Haindrich commented on HIVE-17314:
-----------------------------------------

Seems like this extra if have been introduced in:
https://github.com/apache/hive/commit/d467e172262c23b97e1d55e35798ba530cae5972#diff-b767e13919b57d8131358345ea7192e5R234
Could you upload the patch here as well?
+1

> LazySimpleSerializeWrite.writeString() contains if with an empty body
> ---------------------------------------------------------------------
>
>                 Key: HIVE-17314
>                 URL: https://issues.apache.org/jira/browse/HIVE-17314
>             Project: Hive
>          Issue Type: Bug
>            Reporter: Oleg Danilov
>            Assignee: Oleg Danilov
>            Priority: Minor
>
> Looking at the LazySimpleSerializeWrite.java I found odd 'if':
> Lines 234-235:
> {code:java}
>     if (v.equals(nullSequenceBytes)) {
>     }
> {code}
> Seems like either something is missed there or this 'if' could be dropped out.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message