hive-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HIVE-17290) Should use equals() rather than == to compare strings
Date Thu, 10 Aug 2017 13:03:00 GMT

    [ https://issues.apache.org/jira/browse/HIVE-17290?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16121576#comment-16121576
] 

ASF GitHub Bot commented on HIVE-17290:
---------------------------------------

GitHub user dosoft opened a pull request:

    https://github.com/apache/hive/pull/226

    HIVE-17290: Use equals() rather than == to compare strings

    

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/dosoft/hive HIVE-17290

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/hive/pull/226.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #226
    
----
commit 6cc3f0b952b701305037cd861e9bfbb3f604c023
Author: Oleg Danilov <oleg.danilov@wandisco.com>
Date:   2017-08-10T12:55:10Z

    HIVE-17290: Use equals() rather than == to compare strings

----


> Should use equals() rather than == to compare strings
> -----------------------------------------------------
>
>                 Key: HIVE-17290
>                 URL: https://issues.apache.org/jira/browse/HIVE-17290
>             Project: Hive
>          Issue Type: Bug
>            Reporter: Oleg Danilov
>            Priority: Trivial
>
> There are number of places, where strings have been compared with == or !=. Seems like
it works now, thanks to string interning, but it would be better not to be relied upon.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message