hive-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Xuefu Zhang (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HIVE-17257) Hive should merge empty files
Date Mon, 07 Aug 2017 17:52:01 GMT

    [ https://issues.apache.org/jira/browse/HIVE-17257?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16116933#comment-16116933
] 

Xuefu Zhang commented on HIVE-17257:
------------------------------------

Patch looks simple and good to me. Is it possible to have a test case on this?

> Hive should merge empty files
> -----------------------------
>
>                 Key: HIVE-17257
>                 URL: https://issues.apache.org/jira/browse/HIVE-17257
>             Project: Hive
>          Issue Type: Bug
>            Reporter: Chao Sun
>            Assignee: Chao Sun
>         Attachments: HIVE-17257.0.patch
>
>
> Currently if merging file option is turned on and the dest dir contains large number
of empty files, Hive will not trigger merge task:
> {code}
>   private long getMergeSize(FileSystem inpFs, Path dirPath, long avgSize) {
>     AverageSize averageSize = getAverageSize(inpFs, dirPath);
>     if (averageSize.getTotalSize() <= 0) {
>       return -1;
>     }
>     if (averageSize.getNumFiles() <= 1) {
>       return -1;
>     }
>     if (averageSize.getTotalSize()/averageSize.getNumFiles() < avgSize) {
>       return averageSize.getTotalSize();
>     }
>     return -1;
>   }
> {code}
> This logic doesn't seem right as the it seems better to combine these empty files into
one.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message