Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 6EE6D200CD3 for ; Fri, 28 Jul 2017 22:10:04 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 67494168D3F; Fri, 28 Jul 2017 20:10:04 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id ACC9E168D2C for ; Fri, 28 Jul 2017 22:10:03 +0200 (CEST) Received: (qmail 98858 invoked by uid 500); 28 Jul 2017 20:10:02 -0000 Mailing-List: contact issues-help@hive.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hive.apache.org Delivered-To: mailing list issues@hive.apache.org Received: (qmail 98849 invoked by uid 99); 28 Jul 2017 20:10:02 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 28 Jul 2017 20:10:02 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id 7FA2D180707 for ; Fri, 28 Jul 2017 20:10:02 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -100.002 X-Spam-Level: X-Spam-Status: No, score=-100.002 tagged_above=-999 required=6.31 tests=[RP_MATCHES_RCVD=-0.001, SPF_PASS=-0.001, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id PnsblwHINiq4 for ; Fri, 28 Jul 2017 20:10:01 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id 75EBE5FD7D for ; Fri, 28 Jul 2017 20:10:01 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id ED52CE0AB0 for ; Fri, 28 Jul 2017 20:10:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 8A38E2464C for ; Fri, 28 Jul 2017 20:10:00 +0000 (UTC) Date: Fri, 28 Jul 2017 20:10:00 +0000 (UTC) From: "Alan Gates (JIRA)" To: issues@hive.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HIVE-17189) Fix backwards incompatibility in HiveMetaStoreClient MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Fri, 28 Jul 2017 20:10:04 -0000 [ https://issues.apache.org/jira/browse/HIVE-17189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16105597#comment-16105597 ] Alan Gates commented on HIVE-17189: ----------------------------------- Adding a test that exercises the "new" code paths would be good, especially for the alter_table call. Other than that, +1. > Fix backwards incompatibility in HiveMetaStoreClient > ---------------------------------------------------- > > Key: HIVE-17189 > URL: https://issues.apache.org/jira/browse/HIVE-17189 > Project: Hive > Issue Type: Bug > Components: Metastore > Affects Versions: 2.1.1 > Reporter: Vihang Karajgaonkar > Assignee: Vihang Karajgaonkar > Attachments: HIVE-17189.01.patch > > > HIVE-12730 adds the ability to edit the basic stats using {{alter table}} and {{alter partition}} commands. However, it changes the signature of @public interface of MetastoreClient and removes some methods which breaks backwards compatibility. This can be fixed easily by re-introducing the removed methods and making them call into newly added method {{alter_table_with_environment_context}} -- This message was sent by Atlassian JIRA (v6.4.14#64029)