Mailing-List: contact issues-help@hive.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@hive.apache.org
Date: Mon, 24 Jul 2017 20:14:00 +0000 (UTC)
From: "Chao Sun (JIRA)" <jira@apache.org>
To: issues@hive.apache.org
Message-ID: <JIRA.13088057.1500409911000.1036.1500927240232@Atlassian.JIRA>
In-Reply-To: <JIRA.13088057.1500409911000@Atlassian.JIRA>
References: <JIRA.13088057.1500409911000@Atlassian.JIRA> <JIRA.13088057.1500409911912@jira-lw-us.apache.org>
Subject: [jira] [Commented] (HIVE-17117) Metalisteners are not notified when
 threadlocal metaconf is cleanup
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Mon, 24 Jul 2017 20:14:05 -0000


    [ https://issues.apache.org/jira/browse/HIVE-17117?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16099064#comment-16099064 ] 

Chao Sun commented on HIVE-17117:
---------------------------------

Tests failures are not related. Committed this to master. Thanks [~pgolash] for the patch, and [~mohitsabharwal] and [~zshao] for the review.

> Metalisteners are not notified when threadlocal metaconf is cleanup 
> --------------------------------------------------------------------
>
>                 Key: HIVE-17117
>                 URL: https://issues.apache.org/jira/browse/HIVE-17117
>             Project: Hive
>          Issue Type: Bug
>          Components: Metastore
>         Environment: Tested on master branch (Applicable for downlevel versions as well)
>            Reporter: PRASHANT GOLASH
>            Assignee: PRASHANT GOLASH
>            Priority: Minor
>             Fix For: 3.0.0
>
>         Attachments: HIVE-17117.1.patch, HIVE-17117.patch
>
>
> Meta listeners are not notified of meta-conf cleanup. This could potentially leave stale values on listeners objects. For e.g.
> Request1
> a. HS2 -> HMS : HMSHandler#setMetaConf
>      MetaListeners are notified of the ConfigChangeEvent.
> b. HS2 -> HMS : HMSHandler#shutdown / HiveMetaStore#deleteContext (if shutdown is not invoked)
>     MetaConf is cleaned up in HiveMetaStore#cleanupRawStore, but meta listeners are not notified
> Request 2
> 3. HS2->HMS : AlterPartition
>      MetaListeners are notified of AlterPartitionEvent. If any listener has taken dependency on the meta conf value, it will still be having stale value from Request1 and would potentially be having issues.
> The correct behavior should be to notify meta listeners on cleanup as well.


--
This message was sent by Atlassian JIRA
(v6.4.14#64029)