Mailing-List: contact issues-help@hive.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@hive.apache.org
Date: Mon, 3 Jul 2017 04:32:00 +0000 (UTC)
From: "Sahil Takiar (JIRA)" <jira@apache.org>
To: issues@hive.apache.org
Message-ID: <JIRA.13081537.1498075829000.156716.1499056320163@Atlassian.JIRA>
In-Reply-To: <JIRA.13081537.1498075829000@Atlassian.JIRA>
References: <JIRA.13081537.1498075829000@Atlassian.JIRA> <JIRA.13081537.1498075829973@jira-lw-us.apache.org>
Subject: [jira] [Commented] (HIVE-16935) Hive should strip comments from
 input before choosing which CommandProcessor to run.
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
archived-at: Mon, 03 Jul 2017 04:32:08 -0000


    [ https://issues.apache.org/jira/browse/HIVE-16935?page=3Dcom.atlassian=
.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D1607=
1909#comment-16071909 ]=20

Sahil Takiar commented on HIVE-16935:
-------------------------------------

[~spena] could you help review this patch? Peter and I have already provide=
d some comments on the RB: https://reviews.apache.org/r/60445/

> Hive should strip comments from input before choosing which CommandProces=
sor to run.
> -------------------------------------------------------------------------=
-----------
>
>                 Key: HIVE-16935
>                 URL: https://issues.apache.org/jira/browse/HIVE-16935
>             Project: Hive
>          Issue Type: Bug
>            Reporter: Andrew Sherman
>            Assignee: Andrew Sherman
>         Attachments: HIVE-16935.1.patch, HIVE-16935.2.patch, HIVE-16935.3=
.patch
>
>
> While using Beeswax, Hue fails to execute statement with following error:
> Error while compiling statement: FAILED: ParseException line 3:4 missing =
KW_ROLE at 'a' near 'a' line 3:5 missing EOF at '=3D' near 'a'
> {quote}
> -- comment
> SET a=3D1;
> SELECT 1;
> {quote}
> The same code works in Beeline and in Impala.
> The same code fails in CliDriver=20
> =20
> h2. Background
> Hive deals with sql comments (=E2=80=9C-- to end of line=E2=80=9D) in dif=
ferent places.
> Some clients attempt to strip comments. For example BeeLine was recently =
enhanced in https://issues.apache.org/jira/browse/HIVE-13864 to strip comme=
nts from multi-line commands before they are executed.
> Other clients such as Hue or Jdbc do not strip comments before sending te=
xt.
> Some tests such as TestCliDriver strip comments before running tests.
> When Hive gets a command the CommandProcessorFactory looks at the text to=
 determine which CommandProcessor should handle the command. In the bug cas=
e the correct CommandProcessor is SetProcessor, but the comments confuse th=
e CommandProcessorFactory and so the command is treated as sql. Hive=E2=80=
=99s sql parser understands and ignores comments, but it does not understan=
d the set commands usually handled by SetProcessor and so we get the ParseE=
xception shown above.
> =20


--
This message was sent by Atlassian JIRA
(v6.4.14#64029)