hive-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Rui Li (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (HIVE-16945) Add method to compare Operators
Date Thu, 27 Jul 2017 11:54:00 GMT

     [ https://issues.apache.org/jira/browse/HIVE-16945?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Rui Li updated HIVE-16945:
--------------------------
    Attachment: HIVE-16945.1.patch

Since we're essentially comparing OperatorDesc of each operator, patch v1 just removes OperatorComparatorFactory
and moves the logic to each OperatorDesc - so that we can reuse code.

> Add method to compare Operators 
> --------------------------------
>
>                 Key: HIVE-16945
>                 URL: https://issues.apache.org/jira/browse/HIVE-16945
>             Project: Hive
>          Issue Type: Improvement
>          Components: Operators
>    Affects Versions: 3.0.0
>            Reporter: Jesus Camacho Rodriguez
>            Assignee: Rui Li
>         Attachments: HIVE-16945.1.patch
>
>
> HIVE-10844 introduced a comparator factory class for operators that encapsulates all
the logic to assess whether two operators are equal:
> https://github.com/apache/hive/blob/master/ql/src/java/org/apache/hadoop/hive/ql/optimizer/OperatorComparatorFactory.java
> The current design might create problems as any change in fields of operators will break
the comparators. It would be better to do this via inheritance from Operator base class, by
adding a {{logicalEquals(Operator other)}} method.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message