hive-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Daniel Voros (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HIVE-16880) Remove ArrayList Instantiation For Empty Arrays
Date Wed, 12 Jul 2017 15:05:00 GMT

    [ https://issues.apache.org/jira/browse/HIVE-16880?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16084108#comment-16084108
] 

Daniel Voros commented on HIVE-16880:
-------------------------------------

[~belugabehr] are you sure that using immutable lists won't affect the behavior in these cases?
For example [here|https://github.com/apache/hive/commit/8f004997025f032242a5b2db4c6baf9256e0ecbd#diff-6b5f3b952d1387946d488fc2d4432ee1R1228]
in the constructor of AggrStats the list will be stored as a field and we might try to add
to it later.

> Remove ArrayList Instantiation For Empty Arrays
> -----------------------------------------------
>
>                 Key: HIVE-16880
>                 URL: https://issues.apache.org/jira/browse/HIVE-16880
>             Project: Hive
>          Issue Type: Improvement
>          Components: Metastore
>    Affects Versions: 2.1.1, 3.0.0
>            Reporter: BELUGA BEHR
>            Assignee: BELUGA BEHR
>            Priority: Trivial
>             Fix For: 3.0.0
>
>         Attachments: HIVE-16880.1.patch, HIVE-16880.2.patch
>
>
> Class {{org.apache.hadoop.hive.metastore.MetaStoreDirectSql}} uses a lot of empty arrays
in the code.  Please replace with a static empty array instead of all the instantiation.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message