Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 53692200CAE for ; Wed, 21 Jun 2017 20:27:05 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 517BC160BF0; Wed, 21 Jun 2017 18:27:05 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 969D3160BD0 for ; Wed, 21 Jun 2017 20:27:04 +0200 (CEST) Received: (qmail 20430 invoked by uid 500); 21 Jun 2017 18:27:03 -0000 Mailing-List: contact issues-help@hive.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hive.apache.org Delivered-To: mailing list issues@hive.apache.org Received: (qmail 20421 invoked by uid 99); 21 Jun 2017 18:27:03 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 21 Jun 2017 18:27:03 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id 53157CC7F0 for ; Wed, 21 Jun 2017 18:27:03 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -99.202 X-Spam-Level: X-Spam-Status: No, score=-99.202 tagged_above=-999 required=6.31 tests=[KAM_ASCII_DIVIDERS=0.8, RP_MATCHES_RCVD=-0.001, SPF_PASS=-0.001, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id Fkp5CZsBYpu9 for ; Wed, 21 Jun 2017 18:27:02 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id 1337A5FC6C for ; Wed, 21 Jun 2017 18:27:02 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 1B07AE0DBB for ; Wed, 21 Jun 2017 18:27:01 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 6411F240B9 for ; Wed, 21 Jun 2017 18:27:00 +0000 (UTC) Date: Wed, 21 Jun 2017 18:27:00 +0000 (UTC) From: "Xiaomeng Zhang (JIRA)" To: issues@hive.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Comment Edited] (HIVE-16914) Change HiveMetaStoreClient to AutoCloseable MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Wed, 21 Jun 2017 18:27:05 -0000 [ https://issues.apache.org/jira/browse/HIVE-16914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16057976#comment-16057976 ] Xiaomeng Zhang edited comment on HIVE-16914 at 6/21/17 6:26 PM: ---------------------------------------------------------------- I run test org.apache.hive.jdbc.TestJdbcWithMiniHS2.testHttpRetryOnServerIdleTimeout locally and it can pass. {code:java} ------------------------------------------------------- T E S T S ------------------------------------------------------- Running org.apache.hive.jdbc.TestJdbcWithMiniHS2 Tests run: 26, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 107.34 sec - in org.apache.hive.jdbc.TestJdbcWithMiniHS2 Results : Tests run: 26, Failures: 0, Errors: 0, Skipped: 0 {code} And took a look at newest preCommit build, this test also fails, seems to be a flaky one. https://builds.apache.org/job/PreCommit-HIVE-Build/5717/#showFailuresLink was (Author: xiaomeng zhang): I run test org.apache.hive.jdbc.TestJdbcWithMiniHS2.testHttpRetryOnServerIdleTimeout locally and it can pass. {code:java} ------------------------------------------------------- T E S T S ------------------------------------------------------- Running org.apache.hive.jdbc.TestJdbcWithMiniHS2 Tests run: 26, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 107.34 sec - in org.apache.hive.jdbc.TestJdbcWithMiniHS2 Results : Tests run: 26, Failures: 0, Errors: 0, Skipped: 0 {code} And looks newest preCommit build, this test also fails, seems to be a flaky one. https://builds.apache.org/job/PreCommit-HIVE-Build/5717/#showFailuresLink > Change HiveMetaStoreClient to AutoCloseable > ------------------------------------------- > > Key: HIVE-16914 > URL: https://issues.apache.org/jira/browse/HIVE-16914 > Project: Hive > Issue Type: Improvement > Components: Metastore > Reporter: Xiaomeng Zhang > Assignee: Xiaomeng Zhang > Priority: Trivial > Attachments: HIVE-16914.01.patch > > > During my usage of HiveMetaStoreClient for testing, I found that this class is not AutoCloseable. Adding this change to support > try(HiveMetaStoreClient hmsClient = HiveEnv.createHMSClient()) { > ... > ... > ... > ... > } > So we don't have to manually close it in finally block. -- This message was sent by Atlassian JIRA (v6.4.14#64029)