Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 8AB57200CB0 for ; Fri, 9 Jun 2017 02:50:32 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 89317160BE5; Fri, 9 Jun 2017 00:50:32 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id CED99160BD5 for ; Fri, 9 Jun 2017 02:50:31 +0200 (CEST) Received: (qmail 66942 invoked by uid 500); 9 Jun 2017 00:50:30 -0000 Mailing-List: contact issues-help@hive.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hive.apache.org Delivered-To: mailing list issues@hive.apache.org Received: (qmail 66933 invoked by uid 99); 9 Jun 2017 00:50:30 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 09 Jun 2017 00:50:30 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id C26381809A1 for ; Fri, 9 Jun 2017 00:50:29 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -99.202 X-Spam-Level: X-Spam-Status: No, score=-99.202 tagged_above=-999 required=6.31 tests=[KAM_ASCII_DIVIDERS=0.8, RP_MATCHES_RCVD=-0.001, SPF_PASS=-0.001, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id B3ImBMiRMFvC for ; Fri, 9 Jun 2017 00:50:29 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id D04DC5FC97 for ; Fri, 9 Jun 2017 00:50:23 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 984E0E0665 for ; Fri, 9 Jun 2017 00:50:22 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id B07D121E0D for ; Fri, 9 Jun 2017 00:50:19 +0000 (UTC) Date: Fri, 9 Jun 2017 00:50:19 +0000 (UTC) From: "Matt McCline (JIRA)" To: issues@hive.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Assigned] (HIVE-16863) Vectorization: See if instanceof checks added to VectorAssignRow in HIVE-16589 can be removed... MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Fri, 09 Jun 2017 00:50:32 -0000 [ https://issues.apache.org/jira/browse/HIVE-16863?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matt McCline reassigned HIVE-16863: ----------------------------------- > Vectorization: See if instanceof checks added to VectorAssignRow in HIVE-16589 can be removed... > ------------------------------------------------------------------------------------------------ > > Key: HIVE-16863 > URL: https://issues.apache.org/jira/browse/HIVE-16863 > Project: Hive > Issue Type: Bug > Components: Hive > Reporter: Matt McCline > Assignee: Teddy Choi > Priority: Critical > > (Wait for HIVE-16589 commit). > During HIVE-16589 when VectorUDFAdaptor was converted to use VectorAssignRow instead of adding Complex Type variants to setOutputCol we added instanceof checks since data from VectorUDFAdaptor is sometimes a Byte object instead of a ByteWritable, etc. > In code review, Jason suggested we might be able to make use of the output object inspectors. Is there a way to add (perhaps) a 2nd method(s) that can take advantage of its object inspectors and not do instanceof stuff? -- This message was sent by Atlassian JIRA (v6.3.15#6346)