hive-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Vihang Karajgaonkar (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HIVE-16914) Change HiveMetaStoreClient to AutoCloseable
Date Tue, 20 Jun 2017 19:29:00 GMT

    [ https://issues.apache.org/jira/browse/HIVE-16914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16056324#comment-16056324
] 

Vihang Karajgaonkar commented on HIVE-16914:
--------------------------------------------

Looks like most of the test failures have been failing for some time. I see that the below
tests have been failing for many builds before this pre-commit run

{noformat}
 org.apache.hadoop.hive.ql.parse.TestReplicationScenariosAcrossInstances.testBootstrapFunctionReplication
20 sec	4
 org.apache.hadoop.hive.ql.parse.TestReplicationScenariosAcrossInstances.testCreateFunctionWithFunctionBinaryJarsOnHDFS
20 sec	4
 org.apache.hadoop.hive.ql.parse.TestReplicationScenariosAcrossInstances.testCreateFunctionIncrementalReplication
20 sec	4
 org.apache.hive.hcatalog.api.TestHCatClient.testTableSchemaPropagation	44 sec	30
 org.apache.hive.hcatalog.api.TestHCatClient.testPartitionSpecRegistrationWithCustomSchema
42 sec	30
 org.apache.hive.hcatalog.api.TestHCatClient.testPartitionRegistrationWithCustomSchema	43
sec	30
 org.apache.hadoop.hive.cli.TestMiniLlapCliDriver.testCliDriver[orc_ppd_basic]	20 sec	52
 org.apache.hadoop.hive.cli.TestPerfCliDriver.testCliDriver[query14]	9.9 sec	52
 org.apache.hadoop.hive.cli.TestPerfCliDriver.testCliDriver[query94]	1 sec	57
 org.apache.hadoop.hive.cli.TestPerfCliDriver.testCliDriver[query16]
{noformat}

Hi [~Xiaomeng Zhang] Can you please check if org.apache.hive.jdbc.TestJdbcWithMiniHS2.testHttpRetryOnServerIdleTimeout
test failure is related. You may want to search for flaky tests in Hive project under HIVE-15058
if this test failure has already been reported. Thanks!

> Change HiveMetaStoreClient to AutoCloseable
> -------------------------------------------
>
>                 Key: HIVE-16914
>                 URL: https://issues.apache.org/jira/browse/HIVE-16914
>             Project: Hive
>          Issue Type: Improvement
>          Components: Metastore
>            Reporter: Xiaomeng Zhang
>            Assignee: Xiaomeng Zhang
>            Priority: Trivial
>         Attachments: HIVE-16914.01.patch
>
>
> During my usage of HiveMetaStoreClient for testing, I found that this class is not AutoCloseable.
Adding this change to support 
> try(HiveMetaStoreClient hmsClient = HiveEnv.createHMSClient()) {
> ...
> ...
> ...
> ...
> }
> So we don't have to manually close it in finally block.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message