hive-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sankar Hariappan (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HIVE-16844) Fix Connection leak in ObjectStore when new Conf object is used
Date Sat, 17 Jun 2017 05:23:01 GMT

    [ https://issues.apache.org/jira/browse/HIVE-16844?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16052695#comment-16052695
] 

Sankar Hariappan commented on HIVE-16844:
-----------------------------------------

[~sbeeram] Yes, it does create multiple metastore instances with different configurations.
I tried to keep the configurations same and looks it is working now locally. Will submit the
patch and see if the error is gone in pre-commit build.

> Fix Connection leak in ObjectStore when new Conf object is used
> ---------------------------------------------------------------
>
>                 Key: HIVE-16844
>                 URL: https://issues.apache.org/jira/browse/HIVE-16844
>             Project: Hive
>          Issue Type: Bug
>          Components: Metastore
>            Reporter: Sunitha Beeram
>            Assignee: Sunitha Beeram
>             Fix For: 3.0.0
>
>         Attachments: HIVE-16844.1.patch
>
>
> The code path in ObjectStore.java currently leaks BoneCP (or Hikari) connection pools
when a new configuration object is passed in. The code needs to ensure that the persistence-factory
is closed before it is nullified.
> The relevant code is [here|https://github.com/apache/hive/blob/master/metastore/src/java/org/apache/hadoop/hive/metastore/ObjectStore.java#L290].
Note that pmf is set to null, but the underlying connection pool is not closed.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message