hive-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "BELUGA BEHR (JIRA)" <j...@apache.org>
Subject [jira] [Assigned] (HIVE-16805) Utilities isEmptyPath Logging Too Chatty and Uses Bad Format
Date Wed, 14 Jun 2017 01:12:00 GMT

     [ https://issues.apache.org/jira/browse/HIVE-16805?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

BELUGA BEHR reassigned HIVE-16805:
----------------------------------

    Assignee: BELUGA BEHR

> Utilities isEmptyPath Logging Too Chatty and Uses Bad Format
> ------------------------------------------------------------
>
>                 Key: HIVE-16805
>                 URL: https://issues.apache.org/jira/browse/HIVE-16805
>             Project: Hive
>          Issue Type: Improvement
>          Components: Query Processor
>    Affects Versions: 2.1.1, 3.0.0
>            Reporter: BELUGA BEHR
>            Assignee: BELUGA BEHR
>            Priority: Minor
>         Attachments: HIVE-16805.1.patch
>
>
> {code:title=org.apache.hadoop.hive.ql.exec.Utilities}
>   public static boolean isEmptyPath(JobConf job, Path dirPath, Context ctx)
>       throws Exception {
>     if (ctx != null) {
>       ContentSummary cs = ctx.getCS(dirPath);
>       if (cs != null) {
>         LOG.info("Content Summary " + dirPath + "length: " + cs.getLength() + " num files:
"
>             + cs.getFileCount() + " num directories: " + cs.getDirectoryCount());
>         return (cs.getLength() == 0 && cs.getFileCount() == 0 && cs.getDirectoryCount()
<= 1);
>       } else {
>         LOG.info("Content Summary not cached for " + dirPath);
>       }
>     }
>     return isEmptyPath(job, dirPath);
>   }
> {code}
> # This is too chatty.  Logging for caching is not necessary for INFO logging.  Move to
DEBUG
> # Use Log4J's {} format
> # Make the messages more symmetrical - The success message doesn't include the word "cache"
in it at all
> # Missing a space between the path and "length: " so the path is concatenated with the
string "length:"



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message