hive-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Bing Li (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (HIVE-16573) In-place update for HoS can't be disabled
Date Mon, 05 Jun 2017 05:52:04 GMT

    [ https://issues.apache.org/jira/browse/HIVE-16573?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16036565#comment-16036565
] 

Bing Li edited comment on HIVE-16573 at 6/5/17 5:51 AM:
--------------------------------------------------------

Hi, [~ruili] and [~anishek]
Seems that we can't import class SessionState into InPlaceUpdate.java, it will cause module
cycles error during compiling, which is hive-common->hive-exec->hive-common.

I changed it as below:
{quote}
    String engine = HiveConf.getVar(conf, HiveConf.ConfVars.HIVE_EXECUTION_ENGINE);
    boolean inPlaceUpdates = false;

    if (engine.equals("tez"))
      inPlaceUpdates = HiveConf.getBoolVar(conf, HiveConf.ConfVars.TEZ_EXEC_INPLACE_PROGRESS);

    if (engine.equals("spark"))
      inPlaceUpdates = HiveConf.getBoolVar(conf, HiveConf.ConfVars.SPARK_EXEC_INPLACE_PROGRESS);
{quote}

Do you think is ok?



was (Author: libing):
Hi, [~ruili] and [~anishek]
Seems that we can't import class SessionState into InPlaceUpdate.java, it will cause module
cycles error during compiling, which is hive-common->hive-exec->hive-common.

I changed it as below:
    String engine = HiveConf.getVar(conf, HiveConf.ConfVars.HIVE_EXECUTION_ENGINE);
    boolean inPlaceUpdates = false;

    if (engine.equals("tez"))
      inPlaceUpdates = HiveConf.getBoolVar(conf, HiveConf.ConfVars.TEZ_EXEC_INPLACE_PROGRESS);

    if (engine.equals("spark"))
      inPlaceUpdates = HiveConf.getBoolVar(conf, HiveConf.ConfVars.SPARK_EXEC_INPLACE_PROGRESS);

Do you think is ok?


> In-place update for HoS can't be disabled
> -----------------------------------------
>
>                 Key: HIVE-16573
>                 URL: https://issues.apache.org/jira/browse/HIVE-16573
>             Project: Hive
>          Issue Type: Bug
>          Components: Spark
>            Reporter: Rui Li
>            Assignee: Bing Li
>            Priority: Minor
>
> {{hive.spark.exec.inplace.progress}} has no effect



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message