Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id B66B5200C73 for ; Wed, 10 May 2017 10:30:09 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id B283E160BC6; Wed, 10 May 2017 08:30:09 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 031AE160BA8 for ; Wed, 10 May 2017 10:30:08 +0200 (CEST) Received: (qmail 52366 invoked by uid 500); 10 May 2017 08:30:08 -0000 Mailing-List: contact issues-help@hive.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hive.apache.org Delivered-To: mailing list issues@hive.apache.org Received: (qmail 52357 invoked by uid 99); 10 May 2017 08:30:08 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 10 May 2017 08:30:08 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id BECB91A0527 for ; Wed, 10 May 2017 08:30:07 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -100.002 X-Spam-Level: X-Spam-Status: No, score=-100.002 tagged_above=-999 required=6.31 tests=[RP_MATCHES_RCVD=-0.001, SPF_PASS=-0.001, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id ESnhBcll2umT for ; Wed, 10 May 2017 08:30:05 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id 421EC5FC57 for ; Wed, 10 May 2017 08:30:05 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 91DF9E02C7 for ; Wed, 10 May 2017 08:30:04 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 4CCE421E09 for ; Wed, 10 May 2017 08:30:04 +0000 (UTC) Date: Wed, 10 May 2017 08:30:04 +0000 (UTC) From: "Remus Rusanu (JIRA)" To: issues@hive.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Updated] (HIVE-16612) PerfLogger is configurable, but not extensible MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Wed, 10 May 2017 08:30:09 -0000 [ https://issues.apache.org/jira/browse/HIVE-16612?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Remus Rusanu updated HIVE-16612: -------------------------------- Fix Version/s: 3.0.0 Status: Patch Available (was: Open) > PerfLogger is configurable, but not extensible > ---------------------------------------------- > > Key: HIVE-16612 > URL: https://issues.apache.org/jira/browse/HIVE-16612 > Project: Hive > Issue Type: Bug > Components: Query Planning, Query Processor > Reporter: Remus Rusanu > Assignee: Remus Rusanu > Priority: Minor > Fix For: 3.0.0 > > Attachments: HIVE-16612.01.patch > > > {code} > result = (PerfLogger) ReflectionUtils.newInstance(conf.getClassByName( > conf.getVar(HiveConf.ConfVars.HIVE_PERF_LOGGER)), conf); > {code} > The PerfLogger instance is configurable via {{hive.exec.perf.logger}} (HIVE-11891) but the requirement to extend from {{PerfLogger}} cannot be met since HIVE-11149 as the ctor is private. Also useful methods in PerfLogger are also private. I tried to extend PerfLogger for my needs and realized that, as is, the configurability is not usable. At the very least the PerfLogger should make all private members {{protected}}, better the requirement should be an interface not a class. -- This message was sent by Atlassian JIRA (v6.3.15#6346)