Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 13232200C7F for ; Wed, 24 May 2017 11:14:09 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 12197160B9C; Wed, 24 May 2017 09:14:09 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 620F2160BD0 for ; Wed, 24 May 2017 11:14:08 +0200 (CEST) Received: (qmail 31889 invoked by uid 500); 24 May 2017 09:14:07 -0000 Mailing-List: contact issues-help@hive.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hive.apache.org Delivered-To: mailing list issues@hive.apache.org Received: (qmail 31776 invoked by uid 99); 24 May 2017 09:14:07 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 24 May 2017 09:14:07 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id DE4B7C0702 for ; Wed, 24 May 2017 09:14:06 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -99.202 X-Spam-Level: X-Spam-Status: No, score=-99.202 tagged_above=-999 required=6.31 tests=[KAM_ASCII_DIVIDERS=0.8, RP_MATCHES_RCVD=-0.001, SPF_PASS=-0.001, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id GxrhmbBty3FJ for ; Wed, 24 May 2017 09:14:06 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id A8B885F3FE for ; Wed, 24 May 2017 09:14:05 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id E34ADE0D55 for ; Wed, 24 May 2017 09:14:04 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 4B57C21B5A for ; Wed, 24 May 2017 09:14:04 +0000 (UTC) Date: Wed, 24 May 2017 09:14:04 +0000 (UTC) From: "Zoltan Haindrich (JIRA)" To: issues@hive.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HIVE-15051) Test framework integration with findbugs, rat checks etc. MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Wed, 24 May 2017 09:14:09 -0000 [ https://issues.apache.org/jira/browse/HIVE-15051?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16022580#comment-16022580 ] Zoltan Haindrich commented on HIVE-15051: ----------------------------------------- interesting...they might be using that for some reason...the source doesn't reference it... I've seen it in the link you posted earlier: https://issues.apache.org/jira/browse/YARN-6363?focusedCommentId=15937570&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-15937570 - somewhere at the end there is a note: {{Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org}} yes...it could simplify the wrapper a bit :) I'll continue commenting on the new ticket then! :D > Test framework integration with findbugs, rat checks etc. > --------------------------------------------------------- > > Key: HIVE-15051 > URL: https://issues.apache.org/jira/browse/HIVE-15051 > Project: Hive > Issue Type: Sub-task > Components: Testing Infrastructure > Reporter: Peter Vary > Assignee: Peter Vary > Attachments: beeline.out, HIVE-15051.patch, Interim.patch, ql.out > > > Find a way to integrate code analysis tools like findbugs, rat checks to PreCommit tests, thus removing the burden from reviewers to check the code style and other checks which could be done by code. > Might worth to take a look on Yetus, but keep in mind the Hive has a specific parallel test framework. -- This message was sent by Atlassian JIRA (v6.3.15#6346)