Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 2F1C7200C7F for ; Wed, 24 May 2017 10:27:08 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 2D92E160BB4; Wed, 24 May 2017 08:27:08 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 732BD160B9C for ; Wed, 24 May 2017 10:27:07 +0200 (CEST) Received: (qmail 29893 invoked by uid 500); 24 May 2017 08:27:06 -0000 Mailing-List: contact issues-help@hive.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hive.apache.org Delivered-To: mailing list issues@hive.apache.org Received: (qmail 29884 invoked by uid 99); 24 May 2017 08:27:06 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 24 May 2017 08:27:06 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id 478BB1A0E21 for ; Wed, 24 May 2017 08:27:06 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -99.202 X-Spam-Level: X-Spam-Status: No, score=-99.202 tagged_above=-999 required=6.31 tests=[KAM_ASCII_DIVIDERS=0.8, RP_MATCHES_RCVD=-0.001, SPF_PASS=-0.001, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id IxVP_33242cp for ; Wed, 24 May 2017 08:27:05 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id 4C3635FCCD for ; Wed, 24 May 2017 08:27:05 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id D0295E0D77 for ; Wed, 24 May 2017 08:27:04 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 3759121B5A for ; Wed, 24 May 2017 08:27:04 +0000 (UTC) Date: Wed, 24 May 2017 08:27:04 +0000 (UTC) From: "Zoltan Haindrich (JIRA)" To: issues@hive.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HIVE-15051) Test framework integration with findbugs, rat checks etc. MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Wed, 24 May 2017 08:27:08 -0000 [ https://issues.apache.org/jira/browse/HIVE-15051?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16022527#comment-16022527 ] Zoltan Haindrich commented on HIVE-15051: ----------------------------------------- [~pvary] it seems to me that the hadoop guys are using some docker containers to execute yetus....and somehow they are already using 0.5.0-SNAPSHOT...I suspect that they have faced similar issues deploying/using yetus - like missing patches. I think it would be great to containerize the yetus runner. That way the current extra "patching" could be described in the Dockerfile. hadoop yetus image: https://github.com/apache/hadoop/blob/trunk/dev-support/bin/create-release#L457 https://github.com/apache/hadoop/blob/trunk/dev-support/docker/Dockerfile what do you think about it? > Test framework integration with findbugs, rat checks etc. > --------------------------------------------------------- > > Key: HIVE-15051 > URL: https://issues.apache.org/jira/browse/HIVE-15051 > Project: Hive > Issue Type: Sub-task > Components: Testing Infrastructure > Reporter: Peter Vary > Assignee: Peter Vary > Attachments: beeline.out, HIVE-15051.patch, Interim.patch, ql.out > > > Find a way to integrate code analysis tools like findbugs, rat checks to PreCommit tests, thus removing the burden from reviewers to check the code style and other checks which could be done by code. > Might worth to take a look on Yetus, but keep in mind the Hive has a specific parallel test framework. -- This message was sent by Atlassian JIRA (v6.3.15#6346)