hive-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hive QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HIVE-16743) BitSet set() is not incorrectly used in TxnUtils.createValidCompactTxnList()
Date Wed, 24 May 2017 01:21:04 GMT

    [ https://issues.apache.org/jira/browse/HIVE-16743?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16022178#comment-16022178
] 

Hive QA commented on HIVE-16743:
--------------------------------



Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12869541/HIVE-16743.1.patch

{color:green}SUCCESS:{color} +1 due to 1 test(s) being added or modified.

{color:red}ERROR:{color} -1 due to 2 failed/errored test(s), 10749 tests executed
*Failed tests:*
{noformat}
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[subquery_scalar] (batchId=151)
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[vector_join30] (batchId=149)
{noformat}

Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/5406/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/5406/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-5406/

Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
Tests exited with: TestsFailedException: 2 tests failed
{noformat}

This message is automatically generated.

ATTACHMENT ID: 12869541 - PreCommit-HIVE-Build

> BitSet set() is not incorrectly used in TxnUtils.createValidCompactTxnList()
> ----------------------------------------------------------------------------
>
>                 Key: HIVE-16743
>                 URL: https://issues.apache.org/jira/browse/HIVE-16743
>             Project: Hive
>          Issue Type: Bug
>          Components: Transactions
>    Affects Versions: 3.0.0
>            Reporter: Wei Zheng
>            Assignee: Wei Zheng
>         Attachments: HIVE-16743.1.patch
>
>
> The second line is problematic
> {code}
>     BitSet bitSet = new BitSet(exceptions.length);
>     bitSet.set(0, bitSet.length()); // for ValidCompactorTxnList, everything in exceptions
are aborted
> {code}
> For example, exceptions' length is 2. We declare a BitSet object with initial size of
2 via the first line above. But that's not the actual size of the BitSet. So bitSet.length()
will still return 0.
> The intention of the second line above is to set all the bits to true. This was not achieved
because bitSet.set(0, bitSet.length()) is equivalent to bitSet.set(0, 0).



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message