hive-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Peter Vary (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HIVE-16645) Commands.java has missed the catch statement and has some code format errors
Date Fri, 12 May 2017 09:22:04 GMT

    [ https://issues.apache.org/jira/browse/HIVE-16645?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16007844#comment-16007844
] 

Peter Vary commented on HIVE-16645:
-----------------------------------

Thanks for the patch [~txhsj]!

I was eyeing this rs, stmt closure too, but I did not have time to work on this yet :)

The patch looks good to me, and the test failures should not be related.
But it is strange to have so many failures, so it would be good to attach the same patch again
with a different name (HIVE-16645.2.patch), so the Pre-Commit test should run again.

Thanks,
Peter


> Commands.java has missed the catch statement and has some code format errors
> ----------------------------------------------------------------------------
>
>                 Key: HIVE-16645
>                 URL: https://issues.apache.org/jira/browse/HIVE-16645
>             Project: Hive
>          Issue Type: Bug
>    Affects Versions: 3.0.0
>            Reporter: Saijin Huang
>            Assignee: Saijin Huang
>            Priority: Minor
>         Attachments: HIVE-16645.1.patch
>
>
> In commands.java, the catch statement is missing and the Resultset statement is not closed.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message