hive-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hive QA (JIRA)" <>
Subject [jira] [Commented] (HIVE-16612) PerfLogger is configurable, but not extensible
Date Wed, 10 May 2017 11:07:04 GMT


Hive QA commented on HIVE-16612:

Here are the results of testing the latest attachment:

{color:red}ERROR:{color} -1 due to no test(s) being added or modified.

{color:red}ERROR:{color} -1 due to 3 failed/errored test(s), 10666 tests executed
*Failed tests:*
org.apache.hive.hcatalog.pig.TestTextFileHCatStorer.testWriteDate (batchId=179)

Test results:
Console output:
Test logs:

Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
Tests exited with: TestsFailedException: 3 tests failed

This message is automatically generated.

ATTACHMENT ID: 12867271 - PreCommit-HIVE-Build

> PerfLogger is configurable, but not extensible
> ----------------------------------------------
>                 Key: HIVE-16612
>                 URL:
>             Project: Hive
>          Issue Type: Bug
>          Components: Query Planning, Query Processor
>            Reporter: Remus Rusanu
>            Assignee: Remus Rusanu
>            Priority: Minor
>             Fix For: 3.0.0
>         Attachments: HIVE-16612.01.patch
> {code}
>           result = (PerfLogger) ReflectionUtils.newInstance(conf.getClassByName(
>             conf.getVar(HiveConf.ConfVars.HIVE_PERF_LOGGER)), conf);
> {code}
> The PerfLogger instance is configurable via {{hive.exec.perf.logger}} (HIVE-11891) but
the requirement to extend from {{PerfLogger}} cannot be met since HIVE-11149 as the ctor is
private. Also useful methods in PerfLogger are also private. I tried to extend PerfLogger
for my needs and realized that, as is, the configurability is not usable. At the very least
the PerfLogger should make all private members {{protected}}, better the requirement should
be an interface not a class.

This message was sent by Atlassian JIRA

View raw message