Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 4BB10200C6A for ; Wed, 19 Apr 2017 18:48:46 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 4A390160BAA; Wed, 19 Apr 2017 16:48:46 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 6BA53160B9C for ; Wed, 19 Apr 2017 18:48:45 +0200 (CEST) Received: (qmail 82382 invoked by uid 500); 19 Apr 2017 16:48:44 -0000 Mailing-List: contact issues-help@hive.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hive.apache.org Delivered-To: mailing list issues@hive.apache.org Received: (qmail 82361 invoked by uid 99); 19 Apr 2017 16:48:44 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 19 Apr 2017 16:48:44 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id 3CC661A7B1A for ; Wed, 19 Apr 2017 16:48:44 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -97.2 X-Spam-Level: X-Spam-Status: No, score=-97.2 tagged_above=-999 required=6.31 tests=[KAM_ASCII_DIVIDERS=0.8, KAM_BADIPHTTP=2, NORMAL_HTTP_TO_IP=0.001, RP_MATCHES_RCVD=-0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id Ht_wQ61ujpa0 for ; Wed, 19 Apr 2017 16:48:42 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id 843615F2FD for ; Wed, 19 Apr 2017 16:48:42 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 19308E095D for ; Wed, 19 Apr 2017 16:48:42 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id C861521B47 for ; Wed, 19 Apr 2017 16:48:41 +0000 (UTC) Date: Wed, 19 Apr 2017 16:48:41 +0000 (UTC) From: "Hive QA (JIRA)" To: issues@hive.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HIVE-16469) Parquet timestamp table property is not always taken into account MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Wed, 19 Apr 2017 16:48:46 -0000 [ https://issues.apache.org/jira/browse/HIVE-16469?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15975063#comment-15975063 ] Hive QA commented on HIVE-16469: -------------------------------- Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/12864030/HIVE-16469.02.patch {color:green}SUCCESS:{color} +1 due to 3 test(s) being added or modified. {color:red}ERROR:{color} -1 due to 42 failed/errored test(s), 10583 tests executed *Failed tests:* {noformat} org.apache.hadoop.hive.cli.TestBeeLineDriver.testCliDriver[smb_mapjoin_1] (batchId=234) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[parquet_analyze] (batchId=22) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[ppd_windowing2] (batchId=10) org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[vector_if_expr] (batchId=143) org.apache.hadoop.hive.ql.io.parquet.TestArrayCompatibility.testAmbiguousSingleFieldGroupInList (batchId=255) org.apache.hadoop.hive.ql.io.parquet.TestArrayCompatibility.testAvroPrimitiveInList (batchId=255) org.apache.hadoop.hive.ql.io.parquet.TestArrayCompatibility.testAvroSingleFieldGroupInList (batchId=255) org.apache.hadoop.hive.ql.io.parquet.TestArrayCompatibility.testHiveRequiredGroupInList (batchId=255) org.apache.hadoop.hive.ql.io.parquet.TestArrayCompatibility.testMultiFieldGroupInList (batchId=255) org.apache.hadoop.hive.ql.io.parquet.TestArrayCompatibility.testNewOptionalGroupInList (batchId=255) org.apache.hadoop.hive.ql.io.parquet.TestArrayCompatibility.testNewRequiredGroupInList (batchId=255) org.apache.hadoop.hive.ql.io.parquet.TestArrayCompatibility.testThriftPrimitiveInList (batchId=255) org.apache.hadoop.hive.ql.io.parquet.TestArrayCompatibility.testThriftSingleFieldGroupInList (batchId=255) org.apache.hadoop.hive.ql.io.parquet.TestArrayCompatibility.testUnannotatedListOfGroups (batchId=255) org.apache.hadoop.hive.ql.io.parquet.TestArrayCompatibility.testUnannotatedListOfPrimitives (batchId=255) org.apache.hadoop.hive.ql.io.parquet.TestMapStructures.testDoubleMapWithStructValue (batchId=254) org.apache.hadoop.hive.ql.io.parquet.TestMapStructures.testMapWithComplexKey (batchId=254) org.apache.hadoop.hive.ql.io.parquet.TestMapStructures.testNestedMap (batchId=254) org.apache.hadoop.hive.ql.io.parquet.TestMapStructures.testStringMapOfOptionalArray (batchId=254) org.apache.hadoop.hive.ql.io.parquet.TestMapStructures.testStringMapOfOptionalIntArray (batchId=254) org.apache.hadoop.hive.ql.io.parquet.TestMapStructures.testStringMapOptionalPrimitive (batchId=254) org.apache.hadoop.hive.ql.io.parquet.TestMapStructures.testStringMapRequiredPrimitive (batchId=254) org.apache.hadoop.hive.ql.io.parquet.TestParquetRowGroupFilter.testRowGroupFilterTakeEffect (batchId=255) org.apache.hadoop.hive.ql.io.parquet.TestVectorizedColumnReader.decimalRead (batchId=254) org.apache.hadoop.hive.ql.io.parquet.TestVectorizedColumnReader.structReadSomeNull (batchId=254) org.apache.hadoop.hive.ql.io.parquet.TestVectorizedColumnReader.testBinaryRead (batchId=254) org.apache.hadoop.hive.ql.io.parquet.TestVectorizedColumnReader.testBooleanRead (batchId=254) org.apache.hadoop.hive.ql.io.parquet.TestVectorizedColumnReader.testDoubleRead (batchId=254) org.apache.hadoop.hive.ql.io.parquet.TestVectorizedColumnReader.testFloatRead (batchId=254) org.apache.hadoop.hive.ql.io.parquet.TestVectorizedColumnReader.testIntRead (batchId=254) org.apache.hadoop.hive.ql.io.parquet.TestVectorizedColumnReader.testLongRead (batchId=254) org.apache.hadoop.hive.ql.io.parquet.TestVectorizedColumnReader.testNestedStructRead (batchId=254) org.apache.hadoop.hive.ql.io.parquet.TestVectorizedColumnReader.testStructRead (batchId=254) org.apache.hadoop.hive.ql.io.parquet.TestVectorizedDictionaryEncodingColumnReader.decimalRead (batchId=254) org.apache.hadoop.hive.ql.io.parquet.TestVectorizedDictionaryEncodingColumnReader.structReadSomeNull (batchId=254) org.apache.hadoop.hive.ql.io.parquet.TestVectorizedDictionaryEncodingColumnReader.testBinaryRead (batchId=254) org.apache.hadoop.hive.ql.io.parquet.TestVectorizedDictionaryEncodingColumnReader.testDoubleRead (batchId=254) org.apache.hadoop.hive.ql.io.parquet.TestVectorizedDictionaryEncodingColumnReader.testFloatRead (batchId=254) org.apache.hadoop.hive.ql.io.parquet.TestVectorizedDictionaryEncodingColumnReader.testIntRead (batchId=254) org.apache.hadoop.hive.ql.io.parquet.TestVectorizedDictionaryEncodingColumnReader.testLongRead (batchId=254) org.apache.hadoop.hive.ql.io.parquet.TestVectorizedDictionaryEncodingColumnReader.testNestedStructRead (batchId=254) org.apache.hadoop.hive.ql.io.parquet.TestVectorizedDictionaryEncodingColumnReader.testStructRead (batchId=254) {noformat} Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/4760/testReport Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/4760/console Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-4760/ Messages: {noformat} Executing org.apache.hive.ptest.execution.TestCheckPhase Executing org.apache.hive.ptest.execution.PrepPhase Executing org.apache.hive.ptest.execution.ExecutionPhase Executing org.apache.hive.ptest.execution.ReportingPhase Tests exited with: TestsFailedException: 42 tests failed {noformat} This message is automatically generated. ATTACHMENT ID: 12864030 - PreCommit-HIVE-Build > Parquet timestamp table property is not always taken into account > ----------------------------------------------------------------- > > Key: HIVE-16469 > URL: https://issues.apache.org/jira/browse/HIVE-16469 > Project: Hive > Issue Type: Bug > Reporter: Barna Zsombor Klara > Assignee: Barna Zsombor Klara > Attachments: HIVE-16469.01.patch, HIVE-16469.02.patch > > > The parquet timestamp timezone property is currently copied over into the JobConf in the FetchOperator, but this may be too late for some execution paths. > We should: > 1 - copy the property over earlier > 2 - set the default value on the JobConf if no property is set, and fail in the ParquetRecordReader if the property is missing from the JobConf > We should add extra validations for the cases when: > - the property was not set by accident on the JobConf (unexpected execution path) > - an incorrect/invalid timezone id is being set on the table -- This message was sent by Atlassian JIRA (v6.3.15#6346)