Mailing-List: contact issues-help@hive.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@hive.apache.org
Date: Thu, 20 Apr 2017 21:54:04 +0000 (UTC)
From: =?utf-8?Q?Sergio_Pe=C3=B1a_=28JIRA=29?= <jira@apache.org>
To: issues@hive.apache.org
Message-ID: <JIRA.13056113.1489529179000.12036.1492725244193@Atlassian.JIRA>
In-Reply-To: <JIRA.13056113.1489529179000@Atlassian.JIRA>
References: <JIRA.13056113.1489529179000@Atlassian.JIRA> <JIRA.13056113.1489529179207@jira-lw-us.apache.org>
Subject: [jira] [Commented] (HIVE-16213) ObjectStore can leak Queries when
 rollbackTransaction throws an exception
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
archived-at: Thu, 20 Apr 2017 21:54:10 -0000


    [ https://issues.apache.org/jira/browse/HIVE-16213?page=3Dcom.atlassian=
.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D1597=
7621#comment-15977621 ]=20

Sergio Pe=C3=B1a commented on HIVE-16213:
------------------------------------

The patch looks good [~vihangk1].=20
+1

> ObjectStore can leak Queries when rollbackTransaction throws an exception
> -------------------------------------------------------------------------
>
>                 Key: HIVE-16213
>                 URL: https://issues.apache.org/jira/browse/HIVE-16213
>             Project: Hive
>          Issue Type: Bug
>          Components: Hive
>            Reporter: Alexander Kolbasov
>            Assignee: Vihang Karajgaonkar
>         Attachments: HIVE-16213.01.patch
>
>
> In ObjectStore.java there are a few places with the code similar to:
> {code}
>     Query query =3D null;
>     try {
>       openTransaction();
>       query =3D pm.newQuery(Something.class);
>       ...
>       commited =3D commitTransaction();
>     } finally {
>       if (!commited) {
>         rollbackTransaction();
>       }
>       if (query !=3D null) {
>         query.closeAll();
>       }
>     }
> {code}
> The problem is that rollbackTransaction() may throw an exception in which=
 case query.closeAll() wouldn't be executed.=20
> The fix would be to wrap rollbackTransaction in its own try-catch block.


--
This message was sent by Atlassian JIRA
(v6.3.15#6346)