hive-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hive QA (JIRA)" <>
Subject [jira] [Commented] (HIVE-16433) Not nullify rj to avoid NPE due to race condition in ExecDriver.
Date Thu, 13 Apr 2017 05:22:41 GMT


Hive QA commented on HIVE-16433:

Here are the results of testing the latest attachment:

{color:red}ERROR:{color} -1 due to no test(s) being added or modified.

{color:red}ERROR:{color} -1 due to 2 failed/errored test(s), 10571 tests executed
*Failed tests:*
org.apache.hive.jdbc.TestJdbcDriver2.testSelectExecAsync2 (batchId=221)

Test results:
Console output:
Test logs:

Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
Tests exited with: TestsFailedException: 2 tests failed

This message is automatically generated.

ATTACHMENT ID: 12863175 - PreCommit-HIVE-Build

> Not nullify rj to avoid NPE due to race condition in ExecDriver.
> ----------------------------------------------------------------
>                 Key: HIVE-16433
>                 URL:
>             Project: Hive
>          Issue Type: Bug
>            Reporter: zhihai xu
>            Assignee: zhihai xu
>            Priority: Minor
>         Attachments: HIVE-16433.000.patch
> Not nullify rj to avoid NPE due to race condition in ExecDriver. currently  {{rj}} is
set to null in ExecDriver.shutdown which is called from other thread for query cancellation.
It can happen at any time. There is a potential race condition,  the rj is still accessed
after shutdown is called. For example: if the following code is executed right after ExecDriver.shutdown
is called.
> {code}
>       this.jobID = rj.getJobID();
>       updateStatusInQueryDisplay();
>       returnVal = jobExecHelper.progress(rj, jc, ctx);
> {code}
> Currently the purpose of nullifying  rj is mainly to make sure {{rj.killJob()}} is only
called once.
> I will add a flag jobKilled to make sure {{rj.killJob()}} will be only called once.

This message was sent by Atlassian JIRA

View raw message