hive-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Saijin Huang (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (HIVE-15442) Driver.java has a redundancy code
Date Tue, 11 Apr 2017 08:45:41 GMT

     [ https://issues.apache.org/jira/browse/HIVE-15442?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Saijin Huang updated HIVE-15442:
--------------------------------
    Description: 
Driver.java has a  redundancy  code about "explain output", i think the if statement " if
(conf.getBoolVar(ConfVars.HIVE_LOG_EXPLAIN_OUTPUT))" has a repeat judge with the above statement.




  was:
Driver.java has a  redundancy  code,i think the third if statement could be remved.

if (conf.getBoolVar(ConfVars.HIVE_LOG_EXPLAIN_OUTPUT)) {
        String explainOutput = getExplainOutput(sem, plan, tree.dump());
        if (explainOutput != null) {
          if (conf.getBoolVar(ConfVars.HIVE_LOG_EXPLAIN_OUTPUT)) {
            LOG.info("EXPLAIN output for queryid " + queryId + " : " + explainOutput);
          }
          if (conf.isWebUiQueryInfoCacheEnabled()) {
            queryDisplay.setExplainPlan(explainOutput);
          }
        }
      }


> Driver.java has a redundancy  code
> ----------------------------------
>
>                 Key: HIVE-15442
>                 URL: https://issues.apache.org/jira/browse/HIVE-15442
>             Project: Hive
>          Issue Type: Bug
>    Affects Versions: 3.0.0
>            Reporter: Saijin Huang
>            Assignee: Saijin Huang
>            Priority: Minor
>
> Driver.java has a  redundancy  code about "explain output", i think the if statement
" if (conf.getBoolVar(ConfVars.HIVE_LOG_EXPLAIN_OUTPUT))" has a repeat judge with the above
statement. 



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message