hive-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hive QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HIVE-12636) Ensure that all queries (with DbTxnManager) run in a transaction
Date Thu, 20 Apr 2017 13:45:04 GMT

    [ https://issues.apache.org/jira/browse/HIVE-12636?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15976713#comment-15976713
] 

Hive QA commented on HIVE-12636:
--------------------------------



Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12864207/HIVE-12636.10.patch

{color:green}SUCCESS:{color} +1 due to 10 test(s) being added or modified.

{color:red}ERROR:{color} -1 due to 3 failed/errored test(s), 10573 tests executed
*Failed tests:*
{noformat}
org.apache.hadoop.hive.ql.lockmgr.TestDbTxnManager2.testShowTablesLock (batchId=276)
org.apache.hive.jdbc.TestJdbcWithMiniHS2.testEnableThriftSerializeInTasks (batchId=223)
org.apache.hive.jdbc.TestMultiSessionsHS2WithLocalClusterSpark.testSparkQuery (batchId=223)
{noformat}

Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/4790/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/4790/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-4790/

Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
Tests exited with: TestsFailedException: 3 tests failed
{noformat}

This message is automatically generated.

ATTACHMENT ID: 12864207 - PreCommit-HIVE-Build

> Ensure that all queries (with DbTxnManager) run in a transaction
> ----------------------------------------------------------------
>
>                 Key: HIVE-12636
>                 URL: https://issues.apache.org/jira/browse/HIVE-12636
>             Project: Hive
>          Issue Type: Improvement
>          Components: Transactions
>    Affects Versions: 1.0.0
>            Reporter: Eugene Koifman
>            Assignee: Eugene Koifman
>            Priority: Critical
>         Attachments: HIVE-12636.01.patch, HIVE-12636.02.patch, HIVE-12636.03.patch, HIVE-12636.04.patch,
HIVE-12636.05.patch, HIVE-12636.06.patch, HIVE-12636.07.patch, HIVE-12636.09.patch, HIVE-12636.10.patch
>
>
> Assuming Hive is using DbTxnManager
> Currently (as of this writing only auto commit mode is supported), only queries that
write to an Acid table start a transaction.
> Read-only queries don't open a txn but still acquire locks.
> This makes internal structures confusing/odd.
> The are constantly 2 code paths to deal with which is inconvenient and error prone.
> Also, a txn id is convenient "handle" for all locks/resources within a txn.
> Doing thing would mean the client no longer needs to track locks that it acquired.  This
enables further improvements to metastore side of Acid.
> # add metastore call to openTxn() and acquireLocks() in a single call.  this it to make
sure perf doesn't degrade for read-only query.  (Would also be useful for auto commit write
queries)
> # Should RO queries generate txn ids from the same sequence?  (they could for example
use negative values of a different sequence).  Txnid is part of the delta/base file name.
 Currently it's 7 digits.  If we use the same sequence, we'll exceed 7 digits faster. (possible
upgrade issue).  On the other hand there is value in being able to pick txn id and commit
timestamp out of the same logical sequence.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message