Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 422C4200C56 for ; Fri, 31 Mar 2017 03:11:45 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 40DDA160B9A; Fri, 31 Mar 2017 01:11:45 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 85960160B8B for ; Fri, 31 Mar 2017 03:11:44 +0200 (CEST) Received: (qmail 45812 invoked by uid 500); 31 Mar 2017 01:11:43 -0000 Mailing-List: contact issues-help@hive.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hive.apache.org Delivered-To: mailing list issues@hive.apache.org Received: (qmail 45795 invoked by uid 99); 31 Mar 2017 01:11:43 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 31 Mar 2017 01:11:43 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 115BAC0165 for ; Fri, 31 Mar 2017 01:11:43 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -97.201 X-Spam-Level: X-Spam-Status: No, score=-97.201 tagged_above=-999 required=6.31 tests=[KAM_ASCII_DIVIDERS=0.8, KAM_BADIPHTTP=2, NORMAL_HTTP_TO_IP=0.001, RP_MATCHES_RCVD=-0.001, SPF_PASS=-0.001, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id 4zexvGic2m05 for ; Fri, 31 Mar 2017 01:11:42 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id 434355F20C for ; Fri, 31 Mar 2017 01:11:42 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id D6352E05F7 for ; Fri, 31 Mar 2017 01:11:41 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 8F74821DD9 for ; Fri, 31 Mar 2017 01:11:41 +0000 (UTC) Date: Fri, 31 Mar 2017 01:11:41 +0000 (UTC) From: "Hive QA (JIRA)" To: issues@hive.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HIVE-16329) TopN: TopNHash totalFreeMemory computation ignores free memory MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Fri, 31 Mar 2017 01:11:45 -0000 [ https://issues.apache.org/jira/browse/HIVE-16329?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15950131#comment-15950131 ] Hive QA commented on HIVE-16329: -------------------------------- Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/12861318/HIVE-16329.2.patch {color:red}ERROR:{color} -1 due to no test(s) being added or modified. {color:red}ERROR:{color} -1 due to 3 failed/errored test(s), 10540 tests executed *Failed tests:* {noformat} org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[comments] (batchId=35) org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[vector_if_expr] (batchId=141) org.apache.hive.hcatalog.api.TestHCatClient.testTransportFailure (batchId=172) {noformat} Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/4475/testReport Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/4475/console Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-4475/ Messages: {noformat} Executing org.apache.hive.ptest.execution.TestCheckPhase Executing org.apache.hive.ptest.execution.PrepPhase Executing org.apache.hive.ptest.execution.ExecutionPhase Executing org.apache.hive.ptest.execution.ReportingPhase Tests exited with: TestsFailedException: 3 tests failed {noformat} This message is automatically generated. ATTACHMENT ID: 12861318 - PreCommit-HIVE-Build > TopN: TopNHash totalFreeMemory computation ignores free memory > -------------------------------------------------------------- > > Key: HIVE-16329 > URL: https://issues.apache.org/jira/browse/HIVE-16329 > Project: Hive > Issue Type: Bug > Affects Versions: 2.2.0, 3.0.0 > Reporter: Gopal V > Assignee: Gopal V > Attachments: HIVE-16329.1.patch, HIVE-16329.2.patch > > > {code} > // TODO: For LLAP, assumption is off-heap cache. > final long memoryUsedPerExecutor = (memoryMXBean.getHeapMemoryUsage().getUsed() / numExecutors); > // this is total free memory available per executor in case of LLAP > totalFreeMemory = conf.getMaxMemoryAvailable() - memoryUsedPerExecutor; > {code} > {code} > exec.TopNHash: isTez parameters -615768144 = 5312782848 - 71142611912 / 12 > {code} > This turns off the TopNHash entirely causing something trivial like > {code} > select c_custkey, count(1) from customer group by c_custkey limit 10; > {code} > To shuffle 30M rows instead of 10. -- This message was sent by Atlassian JIRA (v6.3.15#6346)