Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 47B23200C45 for ; Tue, 28 Mar 2017 11:15:48 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 464CF160B89; Tue, 28 Mar 2017 09:15:48 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 689DB160B7E for ; Tue, 28 Mar 2017 11:15:47 +0200 (CEST) Received: (qmail 62636 invoked by uid 500); 28 Mar 2017 09:15:45 -0000 Mailing-List: contact issues-help@hive.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hive.apache.org Delivered-To: mailing list issues@hive.apache.org Received: (qmail 62454 invoked by uid 99); 28 Mar 2017 09:15:45 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 28 Mar 2017 09:15:45 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id 309C2181059 for ; Tue, 28 Mar 2017 09:15:45 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -98.001 X-Spam-Level: X-Spam-Status: No, score=-98.001 tagged_above=-999 required=6.31 tests=[KAM_BADIPHTTP=2, NORMAL_HTTP_TO_IP=0.001, RP_MATCHES_RCVD=-0.001, SPF_PASS=-0.001, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id 7G0rAyq7fY3n for ; Tue, 28 Mar 2017 09:15:43 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id D221D5F2FE for ; Tue, 28 Mar 2017 09:15:42 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 12AA8E012E for ; Tue, 28 Mar 2017 09:15:42 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id BF4B125CDC for ; Tue, 28 Mar 2017 09:15:41 +0000 (UTC) Date: Tue, 28 Mar 2017 09:15:41 +0000 (UTC) From: "Hive QA (JIRA)" To: issues@hive.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HIVE-16311) Improve the performance for FastHiveDecimalImpl.fastDivide MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Tue, 28 Mar 2017 09:15:48 -0000 [ https://issues.apache.org/jira/browse/HIVE-16311?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15944841#comment-15944841 ] Hive QA commented on HIVE-16311: -------------------------------- Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/12860816/HIVE-16311.001.patch {color:red}ERROR:{color} -1 due to no test(s) being added or modified. {color:red}ERROR:{color} -1 due to 43 failed/errored test(s), 10514 tests executed *Failed tests:* {noformat} org.apache.hadoop.hive.cli.TestBeeLineDriver.testCliDriver[drop_with_concurrency] (batchId=231) org.apache.hadoop.hive.cli.TestBeeLineDriver.testCliDriver[escape_comments] (batchId=231) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[comments] (batchId=35) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[decimal_precision] (batchId=49) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[decimal_udf] (batchId=9) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[udaf_binarysetfunctions] (batchId=35) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[union36] (batchId=82) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[vector_aggregate_9] (batchId=37) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[vector_decimal_aggregate] (batchId=17) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[vector_decimal_expressions] (batchId=49) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[vector_decimal_precision] (batchId=47) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[vectorization_16] (batchId=40) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[vectorization_9] (batchId=1) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[vectorization_div0] (batchId=64) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[windowing_distinct] (batchId=53) org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[vector_aggregate_9] (batchId=147) org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[vector_decimal_aggregate] (batchId=142) org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[vector_decimal_expressions] (batchId=150) org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[vector_decimal_precision] (batchId=149) org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[vector_decimal_udf] (batchId=157) org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[vectorization_16] (batchId=148) org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[vectorization_9] (batchId=140) org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[vectorization_short_regress] (batchId=149) org.apache.hadoop.hive.cli.TestMiniTezCliDriver.testCliDriver[vectorization_div0] (batchId=95) org.apache.hadoop.hive.cli.TestPerfCliDriver.testCliDriver[query23] (batchId=226) org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver[vector_decimal_aggregate] (batchId=104) org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver[vectorization_16] (batchId=114) org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver[vectorization_9] (batchId=96) org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver[vectorization_div0] (batchId=125) org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver[vectorization_short_regress] (batchId=116) org.apache.hadoop.hive.common.type.TestDecimal128.testDivide (batchId=240) org.apache.hadoop.hive.common.type.TestDecimal128.testDoubleValue (batchId=240) org.apache.hadoop.hive.common.type.TestDecimal128.testFloatValue (batchId=240) org.apache.hadoop.hive.common.type.TestDecimal128.testPiArcsine (batchId=240) org.apache.hadoop.hive.common.type.TestDecimal128.testPiNewton (batchId=240) org.apache.hadoop.hive.common.type.TestHiveDecimal.testSingleWordDivision (batchId=171) org.apache.hadoop.hive.ql.exec.vector.expressions.TestVectorArithmeticExpressions.testDecimalColDivideDecimalScalar (batchId=264) org.apache.hadoop.hive.ql.udaf.TestStreamingAvg.testHiveDecimal_3_4 (batchId=271) org.apache.hadoop.hive.ql.udf.generic.TestGenericUDFOPDivide.testByteDivideShort (batchId=242) org.apache.hadoop.hive.ql.udf.generic.TestGenericUDFOPDivide.testDecimalDivideDecimal (batchId=242) org.apache.hadoop.hive.ql.udf.generic.TestGenericUDFOPDivide.testDecimalDivideDecimal2 (batchId=242) org.apache.hadoop.hive.ql.udf.generic.TestGenericUDFOPDivide.testLongDivideDecimal (batchId=242) org.apache.hive.hcatalog.api.TestHCatClient.testTransportFailure (batchId=172) {noformat} Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/4410/testReport Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/4410/console Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-4410/ Messages: {noformat} Executing org.apache.hive.ptest.execution.TestCheckPhase Executing org.apache.hive.ptest.execution.PrepPhase Executing org.apache.hive.ptest.execution.ExecutionPhase Executing org.apache.hive.ptest.execution.ReportingPhase Tests exited with: TestsFailedException: 43 tests failed {noformat} This message is automatically generated. ATTACHMENT ID: 12860816 - PreCommit-HIVE-Build > Improve the performance for FastHiveDecimalImpl.fastDivide > ---------------------------------------------------------- > > Key: HIVE-16311 > URL: https://issues.apache.org/jira/browse/HIVE-16311 > Project: Hive > Issue Type: Improvement > Affects Versions: 2.2.0 > Reporter: Colin Ma > Assignee: Colin Ma > Fix For: 2.2.0 > > Attachments: HIVE-16311.001.patch > > > FastHiveDecimalImpl.fastDivide is poor performance when evaluate the expression as 12345.67/123.45 > There are 2 points can be improved: > 1. Don't always use HiveDecimal.MAX_SCALE as scale when do the BigDecimal.divide. > 2. Get the precision for BigInteger in a fast way if possible. -- This message was sent by Atlassian JIRA (v6.3.15#6346)