Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 8D9CD200C36 for ; Fri, 10 Mar 2017 13:19:15 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 8C275160B79; Fri, 10 Mar 2017 12:19:15 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id D49E2160B69 for ; Fri, 10 Mar 2017 13:19:14 +0100 (CET) Received: (qmail 55007 invoked by uid 500); 10 Mar 2017 12:19:14 -0000 Mailing-List: contact issues-help@hive.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hive.apache.org Delivered-To: mailing list issues@hive.apache.org Received: (qmail 54998 invoked by uid 99); 10 Mar 2017 12:19:14 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 10 Mar 2017 12:19:14 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id 5E3511A085B for ; Fri, 10 Mar 2017 12:19:13 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 3.452 X-Spam-Level: *** X-Spam-Status: No, score=3.452 tagged_above=-999 required=6.31 tests=[KAM_ASCII_DIVIDERS=0.8, KAM_BADIPHTTP=2, NORMAL_HTTP_TO_IP=0.001, RP_MATCHES_RCVD=-0.001, SPF_NEUTRAL=0.652] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id ApBNUS8bYYkf for ; Fri, 10 Mar 2017 12:19:12 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id B79475F23A for ; Fri, 10 Mar 2017 12:19:06 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 4D2ABE0A4B for ; Fri, 10 Mar 2017 12:19:05 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 9ECB3243BE for ; Fri, 10 Mar 2017 12:19:04 +0000 (UTC) Date: Fri, 10 Mar 2017 12:19:04 +0000 (UTC) From: "Hive QA (JIRA)" To: issues@hive.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HIVE-16174) Update MetricsConstant.WAITING_COMPILE_OPS metric when we aquire lock failed in Driver MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Fri, 10 Mar 2017 12:19:15 -0000 [ https://issues.apache.org/jira/browse/HIVE-16174?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15904981#comment-15904981 ] Hive QA commented on HIVE-16174: -------------------------------- Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/12857297/HIVE-16174.1.patch {color:red}ERROR:{color} -1 due to no test(s) being added or modified. {color:red}ERROR:{color} -1 due to 9 failed/errored test(s), 10336 tests executed *Failed tests:* {noformat} org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver[auto_join_without_localtask] (batchId=96) org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver[auto_sortmerge_join_3] (batchId=96) org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver[date_join1] (batchId=96) org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver[groupby6_noskew] (batchId=96) org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver[mapjoin_test_outer] (batchId=96) org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver[merge2] (batchId=96) org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver[smb_mapjoin_11] (batchId=96) org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver[vectorization_9] (batchId=96) org.apache.hive.jdbc.TestMultiSessionsHS2WithLocalClusterSpark.testSparkQuery (batchId=219) {noformat} Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/4066/testReport Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/4066/console Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-4066/ Messages: {noformat} Executing org.apache.hive.ptest.execution.TestCheckPhase Executing org.apache.hive.ptest.execution.PrepPhase Executing org.apache.hive.ptest.execution.ExecutionPhase Executing org.apache.hive.ptest.execution.ReportingPhase Tests exited with: TestsFailedException: 9 tests failed {noformat} This message is automatically generated. ATTACHMENT ID: 12857297 - PreCommit-HIVE-Build > Update MetricsConstant.WAITING_COMPILE_OPS metric when we aquire lock failed in Driver > -------------------------------------------------------------------------------------- > > Key: HIVE-16174 > URL: https://issues.apache.org/jira/browse/HIVE-16174 > Project: Hive > Issue Type: Bug > Components: Query Planning > Affects Versions: 2.2.0 > Reporter: yunfei liu > Assignee: yunfei liu > Priority: Minor > Fix For: 2.2.0 > > Attachments: HIVE-16174.1.patch > > > In Driver#compileInternal method (as the code snippet below ), we need to update MetricsConstant.WAITING_COMPILE_OPS metric correctly before return if lock can not be acquired. > {code} > Metrics metrics = MetricsFactory.getInstance(); > if (metrics != null) { > metrics.incrementCounter(MetricsConstant.WAITING_COMPILE_OPS, 1); > } > final ReentrantLock compileLock = tryAcquireCompileLock(isParallelEnabled, > command); > if (compileLock == null) { > return ErrorMsg.COMPILE_LOCK_TIMED_OUT.getErrorCode(); > } > {code} -- This message was sent by Atlassian JIRA (v6.3.15#6346)