Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id B7D5B200C39 for ; Thu, 16 Mar 2017 15:51:45 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id B6872160B7A; Thu, 16 Mar 2017 14:51:45 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 0D881160B78 for ; Thu, 16 Mar 2017 15:51:44 +0100 (CET) Received: (qmail 60913 invoked by uid 500); 16 Mar 2017 14:51:44 -0000 Mailing-List: contact issues-help@hive.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hive.apache.org Delivered-To: mailing list issues@hive.apache.org Received: (qmail 60904 invoked by uid 99); 16 Mar 2017 14:51:44 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 16 Mar 2017 14:51:44 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id AA779C152E for ; Thu, 16 Mar 2017 14:51:43 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 1.451 X-Spam-Level: * X-Spam-Status: No, score=1.451 tagged_above=-999 required=6.31 tests=[KAM_ASCII_DIVIDERS=0.8, RP_MATCHES_RCVD=-0.001, SPF_NEUTRAL=0.652] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id 2aX_CQpo3KA9 for ; Thu, 16 Mar 2017 14:51:42 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id AD6525F238 for ; Thu, 16 Mar 2017 14:51:42 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id ED4DCE05C1 for ; Thu, 16 Mar 2017 14:51:41 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id B3EB7254B8 for ; Thu, 16 Mar 2017 14:51:41 +0000 (UTC) Date: Thu, 16 Mar 2017 14:51:41 +0000 (UTC) From: =?utf-8?Q?Sergio_Pe=C3=B1a_=28JIRA=29?= To: issues@hive.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HIVE-16166) HS2 may still waste up to 15% of memory on duplicate strings MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Thu, 16 Mar 2017 14:51:45 -0000 [ https://issues.apache.org/jira/browse/HIVE-16166?page=3Dcom.atlassian= .jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D1592= 8202#comment-15928202 ]=20 Sergio Pe=C3=B1a commented on HIVE-16166: ------------------------------------ [~misha@cloudera.com] HiveQA already finished, but it could not post the re= sults on the JIRA.=20 Here are the results: https://builds.apache.org/view/H-L/view/Hive/job/PreCommit-HIVE-Build/4164/ Test Result (10 failures / +10) org.apache.hadoop.hive.cli.TestMiniLlapCliDriver.testCliDriver[dynamic_part= ition_pruning_2] org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[llap_pa= rtitioned] org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[vectori= zed_dynamic_partition_pruning] org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[vectori= zation_part] org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[dynamic= _partition_pruning] org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[vectori= zation_part_varchar] org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[dynamic= _semijoin_reduction] org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[special= _character_in_tabnames_1] org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[metadat= aonly1] org.apache.hadoop.hive.cli.TestMiniTezCliDriver.testCliDriver[vector_join_p= art_col_char] > HS2 may still waste up to 15% of memory on duplicate strings > ------------------------------------------------------------ > > Key: HIVE-16166 > URL: https://issues.apache.org/jira/browse/HIVE-16166 > Project: Hive > Issue Type: Improvement > Reporter: Misha Dmitriev > Assignee: Misha Dmitriev > Attachments: ch_2_excerpt.txt, HIVE-16166.01.patch > > > A heap dump obtained from one of our users shows that 15% of memory is wa= sted on duplicate strings, despite the recent optimizations that I made. Th= e problematic strings just come from different sources this time. See the e= xcerpt from the jxray (www.jxray.com) analysis attached. > Adding String.intern() calls in the appropriate places reduces the overhe= ad of duplicate strings with this workload to ~6%. The remaining duplicates= come mostly from JDK internal and MapReduce data structures, and thus are = more difficult to fix. -- This message was sent by Atlassian JIRA (v6.3.15#6346)