Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id D0CDC200C2A for ; Wed, 1 Mar 2017 20:12:51 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id CF616160B56; Wed, 1 Mar 2017 19:12:51 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 1F8BF160B70 for ; Wed, 1 Mar 2017 20:12:50 +0100 (CET) Received: (qmail 84328 invoked by uid 500); 1 Mar 2017 19:12:50 -0000 Mailing-List: contact issues-help@hive.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hive.apache.org Delivered-To: mailing list issues@hive.apache.org Received: (qmail 84319 invoked by uid 99); 1 Mar 2017 19:12:50 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 01 Mar 2017 19:12:50 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id E569AC05AA for ; Wed, 1 Mar 2017 19:12:49 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -1.547 X-Spam-Level: X-Spam-Status: No, score=-1.547 tagged_above=-999 required=6.31 tests=[KAM_ASCII_DIVIDERS=0.8, RP_MATCHES_RCVD=-2.999, SPF_NEUTRAL=0.652] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id KfbGXVY2rc3l for ; Wed, 1 Mar 2017 19:12:49 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id E4AF05F2C5 for ; Wed, 1 Mar 2017 19:12:48 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 85662E04FE for ; Wed, 1 Mar 2017 19:12:45 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 438C12415C for ; Wed, 1 Mar 2017 19:12:45 +0000 (UTC) Date: Wed, 1 Mar 2017 19:12:45 +0000 (UTC) From: "Eugene Koifman (JIRA)" To: issues@hive.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HIVE-15844) Add WriteType to Explain Plan of ReduceSinkOperator and FileSinkOperator MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Wed, 01 Mar 2017 19:12:52 -0000 [ https://issues.apache.org/jira/browse/HIVE-15844?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15890829#comment-15890829 ] Eugene Koifman commented on HIVE-15844: --------------------------------------- TestBeeLineWithArgs.testQueryProgressParallel is unstable, e.g. https://builds.apache.org/job/PreCommit-HIVE-Build/3870/ the other failure has age > 1 > Add WriteType to Explain Plan of ReduceSinkOperator and FileSinkOperator > ------------------------------------------------------------------------ > > Key: HIVE-15844 > URL: https://issues.apache.org/jira/browse/HIVE-15844 > Project: Hive > Issue Type: Bug > Components: Transactions > Reporter: Eugene Koifman > Assignee: Eugene Koifman > Fix For: 1.0.0 > > Attachments: HIVE-15844.01.patch, HIVE-15844.02.patch, HIVE-15844.03.patch, HIVE-15844.04.patch, HIVE-15844.05.patch, HIVE-15844.06.patch, HIVE-15844.07.patch, HIVE-15844.08.patch > > > # both FileSinkDesk and ReduceSinkDesk have special code path for Update/Delete operations. It is not always set correctly for ReduceSink. ReduceSinkDeDuplication is one place where it gets lost. Even when it isn't set correctly, elsewhere we set ROW_ID to be the partition column of the ReduceSinkOperator and UDFToInteger special cases it to extract bucketId from ROW_ID. We need to modify Explain Plan to record Write Type (i.e. insert/update/delete) to make sure we have tests that can catch errors here. > # Add some validation at the end of the plan to make sure that RSO/FSO which represent the end of the pipeline and write to acid table have WriteType set (to something other than default). > # We don't seem to have any tests where number of buckets is > number of reducers. Add those. -- This message was sent by Atlassian JIRA (v6.3.15#6346)