Mailing-List: contact issues-help@hive.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@hive.apache.org
Date: Sun, 19 Mar 2017 15:38:41 +0000 (UTC)
From: "Matt McCline (JIRA)" <jira@apache.org>
To: issues@hive.apache.org
Message-ID: <JIRA.12979218.1465953947000.59902.1489937921637@Atlassian.JIRA>
In-Reply-To: <JIRA.12979218.1465953947000@Atlassian.JIRA>
References: <JIRA.12979218.1465953947000@Atlassian.JIRA> <JIRA.12979218.1465953947763@jira-lw-us.apache.org>
Subject: [jira] [Commented] (HIVE-14016) Vectorization: Add support for
 Grouping Sets
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Sun, 19 Mar 2017 15:38:51 -0000


    [ https://issues.apache.org/jira/browse/HIVE-14016?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15931748#comment-15931748 ] 

Matt McCline commented on HIVE-14016:
-------------------------------------

Committed to master.  Thanks [~gopalv] and [~jcamachorodriguez].

> Vectorization: Add support for Grouping Sets
> --------------------------------------------
>
>                 Key: HIVE-14016
>                 URL: https://issues.apache.org/jira/browse/HIVE-14016
>             Project: Hive
>          Issue Type: Improvement
>          Components: Vectorization
>            Reporter: Gopal V
>            Assignee: Matt McCline
>             Fix For: 2.2.0
>
>         Attachments: HIVE-14016.01.patch, HIVE-14016.02.patch, HIVE-14016.03.patch, HIVE-14016.04.patch, HIVE-14016.05.patch, HIVE-14016.06.patch, HIVE-14016.07.patch, HIVE-14016.091.patch, HIVE-14016.092.patch, HIVE-14016.093.patch, HIVE-14016.09.patch
>
>
> Rollup and Cube queries are not vectorized today due to the miss of grouping-sets inside vector group by.
> The cube and rollup operators can be shimmed onto the end of the pipeline by converting a single row writer into a multiple row writer.
> The corresponding non-vec loop is as follows
> {code}
>       if (groupingSetsPresent) {
>         Object[] newKeysArray = newKeys.getKeyArray();
>         Object[] cloneNewKeysArray = new Object[newKeysArray.length];
>         for (int keyPos = 0; keyPos < groupingSetsPosition; keyPos++) {
>           cloneNewKeysArray[keyPos] = newKeysArray[keyPos];
>         }
>         for (int groupingSetPos = 0; groupingSetPos < groupingSets.size(); groupingSetPos++) {
>           for (int keyPos = 0; keyPos < groupingSetsPosition; keyPos++) {
>             newKeysArray[keyPos] = null;
>           }
>           FastBitSet bitset = groupingSetsBitSet[groupingSetPos];
>           // Some keys need to be left to null corresponding to that grouping set.
>           for (int keyPos = bitset.nextSetBit(0); keyPos >= 0;
>             keyPos = bitset.nextSetBit(keyPos+1)) {
>             newKeysArray[keyPos] = cloneNewKeysArray[keyPos];
>           }
>           newKeysArray[groupingSetsPosition] = newKeysGroupingSets[groupingSetPos];
>           processKey(row, rowInspector);
>         }
>       }
> {code}


--
This message was sent by Atlassian JIRA
(v6.3.15#6346)