Mailing-List: contact issues-help@hive.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@hive.apache.org
Date: Sat, 25 Mar 2017 20:39:41 +0000 (UTC)
From: "Pengcheng Xiong (JIRA)" <jira@apache.org>
To: issues@hive.apache.org
Message-ID: <JIRA.12960892.1461267002000.122991.1490474381776@Atlassian.JIRA>
In-Reply-To: <JIRA.12960892.1461267002000@Atlassian.JIRA>
References: <JIRA.12960892.1461267002000@Atlassian.JIRA> <JIRA.12960892.1461267002825@jira-lw-us.apache.org>
Subject: [jira] [Commented] (HIVE-13584) HBaseStorageHandler should support
 table pre-split
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Sat, 25 Mar 2017 20:39:46 -0000


    [ https://issues.apache.org/jira/browse/HIVE-13584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15941958#comment-15941958 ] 

Pengcheng Xiong commented on HIVE-13584:
----------------------------------------

Hello, I am deferring this to Hive 3.0 as we are going to cut the first RC and it is not marked as blocker. Please feel free to commit to the branch if this can be resolved before the release.

> HBaseStorageHandler should support table pre-split
> --------------------------------------------------
>
>                 Key: HIVE-13584
>                 URL: https://issues.apache.org/jira/browse/HIVE-13584
>             Project: Hive
>          Issue Type: Improvement
>          Components: HBase Handler
>    Affects Versions: 2.0.0
>            Reporter: Svetozar Ivanov
>            Assignee: Svetozar Ivanov
>              Labels: HBase, PreSplit
>         Attachments: HIVE-13584.1.patch, HIVE-13584.2.patch, HIVE-13584.3.patch, HIVE-13584.4.patch, HIVE-13584-branch-2.0.patch, HIVE-13584.patch
>
>
> Currently is not possible creation of HBase table via HBaseStorageHandler with specified pre-split strategy.
> I use it in my code with applied patch in that way:
> {code}
> public String buildCreateTblStatement(TableDescriptor tableDescriptor) {
>         StringBuilder createTableStatement = ...;
>         ...
>         ...
>         String tblProperties = buildTblProperties(tableDescriptor);
>         if (StringUtils.isNotBlank(tblProperties)) {
>              createTableStatement.append(" TBLPROPERTIES (" + tblProperties + ")");
>         }
>          ...
>         return createTableStatement.toString();
> }
> private static String buildTblProperties(TableDescriptor tableDescriptor) {
>         ...
>         ...
>         if (supportsPreSplit(tableDescriptor)) {
>             sb.append(", ");
>             sb.append(quoteInSingleQuotes(HBaseStorageHandler.SPLITS_NUMBER));
>             sb.append(" = ");
>             sb.append(quoteInSingleQuotes(String.valueOf(tableDescriptor.getNumRegions())));
>             GeneratedPKDescriptor columnDescriptor = (GeneratedPKDescriptor) tableDescriptor.getPkDescriptors().get(0);
>             sb.append(", ");
>             sb.append(quoteInSingleQuotes(HBaseStorageHandler.SPLIT_ALGORITHM_FIRSTROW_KEY));
>             sb.append(" = ");
>             sb.append(quoteInSingleQuotes(columnDescriptor.getPkGenerator().firstRowKey()));
>             sb.append(", ");
>             sb.append(quoteInSingleQuotes(HBaseStorageHandler.SPLIT_ALGORITHM_LASTROW_KEY));
>             sb.append(" = ");
>             sb.append(quoteInSingleQuotes(columnDescriptor.getPkGenerator().lastRowKey()));
>         }
>         logger.trace("TBLPROPERTIES are [{}]", sb);
>         return sb.toString();
> }
> {code}


--
This message was sent by Atlassian JIRA
(v6.3.15#6346)