hive-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hive QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HIVE-16206) Make Codahale metrics reporters pluggable
Date Mon, 20 Mar 2017 18:43:41 GMT

    [ https://issues.apache.org/jira/browse/HIVE-16206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15933271#comment-15933271
] 

Hive QA commented on HIVE-16206:
--------------------------------



Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12859579/HIVE-16206.2.patch

{color:green}SUCCESS:{color} +1 due to 1 test(s) being added or modified.

{color:red}ERROR:{color} -1 due to 1 failed/errored test(s), 10478 tests executed
*Failed tests:*
{noformat}
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[comments] (batchId=35)
{noformat}

Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/4248/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/4248/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-4248/

Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
Tests exited with: TestsFailedException: 1 tests failed
{noformat}

This message is automatically generated.

ATTACHMENT ID: 12859579 - PreCommit-HIVE-Build

> Make Codahale metrics reporters pluggable
> -----------------------------------------
>
>                 Key: HIVE-16206
>                 URL: https://issues.apache.org/jira/browse/HIVE-16206
>             Project: Hive
>          Issue Type: Improvement
>          Components: Metastore
>    Affects Versions: 2.1.2
>            Reporter: Sunitha Beeram
>            Assignee: Sunitha Beeram
>         Attachments: HIVE-16206.2.patch, HIVE-16206.patch
>
>
> Hive metrics code currently allows pluggable metrics handlers - ie, handlers that take
care of providing interfaces for metrics collection as well as a reporting; one of the 'handlers'
is CodahaleMetrics. Codahale can work with different reporters - currently supported ones
are Console, JMX, JSON file and hadoop2 sink. However, adding a new reporter involves changing
that class. We would like to make this conf driven just the way MetricsFactory handles configurable
Metrics classes.
> Scope of work:
> - Provide a new configuration option, HIVE_CODAHALE_REPORTER_CLASSES that enumerates
classes (like HIVE_METRICS_CLASS and unlike HIVE_METRICS_REPORTER).
> - Move JsonFileReporter into its own class.
> - Update CodahaleMetrics.java to read new config option and if the new option is not
present, look for the old option and instantiate accordingly) - ie, make the code backward
compatible.
> - Update and add new tests.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message