hive-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sergey Shelukhin (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HIVE-16191) simplify thread usage in TaskExecutorService
Date Tue, 14 Mar 2017 19:02:41 GMT

    [ https://issues.apache.org/jira/browse/HIVE-16191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15924807#comment-15924807
] 

Sergey Shelukhin commented on HIVE-16191:
-----------------------------------------

It is over-engineering - extra classes, extra LOC, extra objects to achieve the exact same
goal. If you want to create one permanent thread, create one permanent thread. If you have
to create TWO executors, one executor wrapper, a future, a and a callback class, to manage
one thread, it's just poor engineering. Of course, if your opinion is in favor poor engineering
or you prefer the "enterprise" low-quality style in small details, it doesn't matter...
Hive codebase has plenty of cruft, so I don't care enough to pursue this JIRA, but I will
definitely -1 this type of code in future.

> simplify thread usage in TaskExecutorService
> --------------------------------------------
>
>                 Key: HIVE-16191
>                 URL: https://issues.apache.org/jira/browse/HIVE-16191
>             Project: Hive
>          Issue Type: Bug
>            Reporter: Sergey Shelukhin
>            Assignee: Sergey Shelukhin
>         Attachments: HIVE-16191.patch
>
>
> Remove executors, futures, decorators etc where not needed



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message