hive-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ian Macalinao (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HIVE-16184) Remove use of optionals in union; declare TProgressUpdateResp before its usage
Date Sun, 19 Mar 2017 01:01:46 GMT

    [ https://issues.apache.org/jira/browse/HIVE-16184?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15931512#comment-15931512
] 

Ian Macalinao commented on HIVE-16184:
--------------------------------------

I see no problem with these Thrift changes. We should not be using optionals in unions anyway.

> Remove use of optionals in union; declare TProgressUpdateResp before its usage
> ------------------------------------------------------------------------------
>
>                 Key: HIVE-16184
>                 URL: https://issues.apache.org/jira/browse/HIVE-16184
>             Project: Hive
>          Issue Type: Bug
>          Components: Thrift API
>            Reporter: Ian Macalinao
>            Assignee: Ian Macalinao
>            Priority: Minor
>         Attachments: HIVE-16184.patch
>
>
> A Scala Thrift generator (https://github.com/twitter/scrooge) does not like the Thrift
file. I have removed some bad Thrift practices (i.e. optionals in union, dependent types declared
after their usage) and replaced them with things that work in Scrooge.
> See https://github.com/apache/hive/pull/157



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message