hive-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Zoltan Haindrich (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HIVE-16178) corr/covar_samp UDAF standard compliance
Date Wed, 22 Mar 2017 06:29:41 GMT

    [ https://issues.apache.org/jira/browse/HIVE-16178?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15935816#comment-15935816
] 

Zoltan Haindrich commented on HIVE-16178:
-----------------------------------------

[~leftylev] I'm not sure what to add...since this have only corrected some small issues at
corner cases...I may possibly add something like:

| corr(y,x) | [...original doc...] As of Hive 0.7.0(HIVE-1549), SQL2011 compliant since HIVE
2.2.0 |

or...should I add an SQL2011 compilant since column, and mark all the functions which currently
seems to have met the criteria? this would need me to go thru all of the existing ones - I
was planning to do this anyway.... 

> corr/covar_samp UDAF standard compliance
> ----------------------------------------
>
>                 Key: HIVE-16178
>                 URL: https://issues.apache.org/jira/browse/HIVE-16178
>             Project: Hive
>          Issue Type: Sub-task
>          Components: SQL
>            Reporter: Zoltan Haindrich
>            Assignee: Zoltan Haindrich
>            Priority: Minor
>              Labels: TODOC2.2
>             Fix For: 2.2.0
>
>         Attachments: HIVE-16178.1.patch, HIVE-16178.2.patch
>
>
> h3. corr
> the standard defines corner cases when it should return null - but the current result
is NaN.
> If N * SUMX2 equals SUMX * SUMX , then the result is the null value.
> and
> If N * SUMY2 equals SUMY * SUMY , then the result is the null value.
> h3. covar_samp
> returns 0 instead 1
> `If N is 1 (one), then the result is the null value.`
> h3. check (x,y) vs (y,x) args in docs
> the standard uses (y,x) order; and some of the function names are also contain X and
Y...so the order does matter..currently at least corr uses (x,y) order which is okay - because
its symmetric; but it would be great to have the same order everywhere (check others)



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message